Giter VIP home page Giter VIP logo

Comments (3)

robx avatar robx commented on May 18, 2024 1

I don't really think this is a good idea, on several different levels...

  1. There's my general feeling that this package is a bit of a poorly designed mess that I don't want to do feature development for. (The recent parsing error change was different in the sense that it made the package do what it does slightly less badly.)

  2. I'm not really sure something like this belongs in a configuration file format. If this is really needed for postgrest, I'd prefer an approach where

    • postgrest would handle the http request itself
    • the API of this package would be adapted as necessary to make it easy to integrate that

    As a related approach, I could expose the low-level parser (Data.Configurator.Syntax), and we could move the interpretation layer over into postgrest itself. Then interpretation of the import directive would be up to postgrest, and this feature could be developed there. If you 'd like this, I'd be happy to make that change.

  3. Would this even address the issue? As far as I understand, the potential users are serving a JSON file somewhere which they'd like integrated into their config, but configurator-pg would expect a file in its own format.

from configurator-pg.

steve-chavez avatar steve-chavez commented on May 18, 2024

Oh, I forgot about the import directive. So maybe it could be like this instead:

db-schema = "test"
jwks = import https://domain.co/jwk

from configurator-pg.

steve-chavez avatar steve-chavez commented on May 18, 2024

There's my general feeling that this package is a bit of a poorly designed mess that I don't want to do feature development for.

Totally understand. No change needed from configurator-pg.

I think now this should be handled in postgrest. Similarly to what we do for an option = @filename config value.(I somehow thought this was handled in configurator-pg, sorry about that).

from configurator-pg.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.