osu!mania NF multiplier in code doesn't match live about osu-performance HOT 7 CLOSED

Ok nevermind I just found why :

1- The scoreMultiplier is recovered using beatmap.DifficultyAttribute(_mods, Beatmap::ScoreMultiplier) here :
https://github.com/ppy/osu-performance/blob/master/src/performance/mania/ManiaScore.cpp#L70

2- The DifficultyAttribute method is defined here and only considers a subselection of mods using MaskRelevantDifficultyMods
https://github.com/ppy/osu-performance/blob/master/src/performance/Beatmap.cpp#L22-L24

3- Of course MaskRelevantDifficultyMods ignores NF :

from osu-performance.

i don't have a code reference but iirc all mania scores under 500k have 0pp. it was to prevent people mashing hard maps for rank

from osu-performance.

nevermind here it is https://github.com/ppy/osu-performance/blob/master/src/performance/mania/ManiaScore.cpp#L86-L88

from osu-performance.

Wow so NF multiplies PP by 0.9, but that doesn't matter because NF also halves score and that makes PP always 0.

from osu-performance.

Before applying the score factor, the score of the play is divided by the score multiplier of the mods applied, so the score multiplier shouldn't have an effect of pp calculation. In fact, other mods that reduce score (EZ, HT) do have pp values above 0.

There seems to be a bug somewhere where the score multiplier of NF isn't being considered.

from osu-performance.

yep as @FullTablet said, it's re-scalled to remove the mod multiplier right here :
https://github.com/ppy/osu-performance/blob/master/src/performance/mania/ManiaScore.cpp#L78
So the error in calculation probably comes from somewhere else outside of ManiaScore.cpp.

I tried searching in the code at what other places the NF mod do have any impact but couldn't find anything yet. Running the pp calculation of a NF play in debug mode in some IDE and tracing back the source of the 0 in the step by step calculation is probably the easiest way to find it, but I've never used C# IDEs/tools.

from osu-performance.

woops, sorry for the misleading comments then

from osu-performance.