Comments (7)
Hey,
Sorry for the late reply. Wow really love your point @Nabhag8848. Agree and +1 with the @schmelto opinion.
from biodrop-cli.
Hey @Pradumnasaraf @schmelto, My name is Nabhag. The above validation looks good, but i think we can have one more validation, which will make sure that the input link points to the user profile and the account exist. so lets take an example of github, to look at user profile we have https://github.com/:username
. Now GET request to URL would either response with status code 200 OK
if the user exist and the user have mention the username correctly else will response with 404 not found
if user not exist or the user have input the wrong username. attaching below example in console for better understanding.
Now using the same analogy, i have tried using leetcode and this seems to work for the same and seems like would work for all the input urls.
conclusion
we can avoid different platform apis to check if the user exist. By making the GET request to the input url. we can let know the user if the input url leads to the correct user profile page if the response status code is 200 OK
else let know the user that input url is wrong or the username doesn't exist.
from biodrop-cli.
What y'all think about the same? I have some questions too.
Question
- making GET request to the website url is expensive?
- will that lead to bad user experience?
That is a great question.
In my opinion we can negligible the response time of the api call due the benefit outweigh the cost.
from biodrop-cli.
Hey! contributor, thank you for opening an Issue 🎉.
Soon one of our maintainers will review it and provide you with feedback/suggestions. If you think it's something urgent, feel free to reach out Pradumna Saraf on Twitter. Star ⭐ this repo to show us support.
Happy, Open Source!
from biodrop-cli.
Thank you for opening the issue @schmelto
from biodrop-cli.
What y'all think about the same? I have some questions too.
Question
- making GET request to the website url is expensive?
- will that lead to bad user experience?
from biodrop-cli.
Closing this issue for now. Thanks for opening
from biodrop-cli.
Related Issues (20)
- [OTHER] Unable to add links HOT 8
- Remove unwanted keys HOT 5
- [FEATURE] Allowing only some changes when overwriting HOT 7
- [BUG] fix `releases.yml` workflow version number HOT 6
- [BUG] Add a name to greetings workflow - `greetings.yml` HOT 5
- Add tags feature HOT 1
- [BUG] Fix the light BG HOT 3
- [BUG] Fix update profile message HOT 8
- [FEATURE] Search filter for icons HOT 24
- [FEATURE] Adding group and color keys for links HOT 18
- [CI] Add missing `title:` property in issue template HOT 12
- [CI] Add missing `value:` property in issue template HOT 7
- [DOCS] update the demo GIF HOT 1
- [DOCS] New demo GIF HOT 2
- [FEATURE] Add profile searching function HOT 1
- [FEATURE] Rename the LinkFree-CLI package HOT 1
- Add more tags to package.json HOT 3
- Fix Issue templates - Add more info in description HOT 3
- [FEATURE] Change to ES6 HOT 1
- [OTHER] Choices code optimization HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from biodrop-cli.