[FEATURE] add validation for links about biodrop-cli HOT 7 CLOSED

Hey,

Sorry for the late reply. Wow really love your point @Nabhag8848. Agree and +1 with the @schmelto opinion.

from biodrop-cli.

Hey @Pradumnasaraf @schmelto, My name is Nabhag. The above validation looks good, but i think we can have one more validation, which will make sure that the input link points to the user profile and the account exist. so lets take an example of github, to look at user profile we have https://github.com/:username. Now GET request to URL would either response with status code 200 OK if the user exist and the user have mention the username correctly else will response with 404 not found if user not exist or the user have input the wrong username. attaching below example in console for better understanding.

Now using the same analogy, i have tried using leetcode and this seems to work for the same and seems like would work for all the input urls.

conclusion

we can avoid different platform apis to check if the user exist. By making the GET request to the input url. we can let know the user if the input url leads to the correct user profile page if the response status code is 200 OK else let know the user that input url is wrong or the username doesn't exist.

from biodrop-cli.

What y'all think about the same? I have some questions too.

Question

• making GET request to the website url is expensive?
• will that lead to bad user experience?

That is a great question.
In my opinion we can negligible the response time of the api call due the benefit outweigh the cost.

from biodrop-cli.

Hey! contributor, thank you for opening an Issue 🎉.

Soon one of our maintainers will review it and provide you with feedback/suggestions. If you think it's something urgent, feel free to reach out Pradumna Saraf on Twitter. Star ⭐ this repo to show us support.

Happy, Open Source!

from biodrop-cli.

Thank you for opening the issue @schmelto

from biodrop-cli.

What y'all think about the same? I have some questions too.

Question

• making GET request to the website url is expensive?
• will that lead to bad user experience?

from biodrop-cli.

Closing this issue for now. Thanks for opening

from biodrop-cli.