Giter VIP home page Giter VIP logo

Comments (10)

Destaq avatar Destaq commented on August 21, 2024

Additionally, the dialog does not close when clicking on any of the buttons, just by clicking outside of it. I have AlpineJS as a src script, on the @click="close" event listeners, but the documentation did not show how to implement the close method.

from kutty.

praveenjuge avatar praveenjuge commented on August 21, 2024

I'll fix the scroll bar bug 👍

Can you share a minimal reproduction repo for the close event not working?

from kutty.

Destaq avatar Destaq commented on August 21, 2024

@praveenjuge Done.
https://github.com/Destaq/broken-kutty-dialog

  1. npm i
  2. npm run build:css
  3. npm run serve = you can click outside the dialog to close it, but not on the buttons...

from kutty.

Destaq avatar Destaq commented on August 21, 2024

This also seems to be the case for another dynamic component, the drawer @praveenjuge . If you look at the drawer branch on the repo, you can see that it does not work as well. No popup shows, the page only dims.

from kutty.

praveenjuge avatar praveenjuge commented on August 21, 2024

Thanks, I'll take a look

from kutty.

Destaq avatar Destaq commented on August 21, 2024

Thanks, I'll take a look

Thank you, I hope it can be resolved.

I tried cloning this repo: #5 that did not use AlpineJS, and the dialog worked perfectly. However, since then the dialog has been changed and no longer works - this may be useful information to you.

from kutty.

Destaq avatar Destaq commented on August 21, 2024

@praveenjuge
I've done some digging and solved the problem, there was a name clash.

Fixed in this PR: #31

Although the dialog creating scrollbar to the right still happens.

from kutty.

praveenjuge avatar praveenjuge commented on August 21, 2024

Hey, I have fixed the issue in the latest commit.

You can check if it's working here: https://codepen.io/praveenjuge/pen/KKNdavv

I'll tag a release soon. Thanks for raising this issue!

from kutty.

Destaq avatar Destaq commented on August 21, 2024

Works great, thanks for fixing and making Kutty!

from kutty.

praveenjuge avatar praveenjuge commented on August 21, 2024

Fixed in release 0.5.0

from kutty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.