Giter VIP home page Giter VIP logo

Comments (4)

blanquer avatar blanquer commented on July 17, 2024

yes, we do have that issue in general (as #99 sort of states).
This particular case of the attributes method, though, I think is a slightly different, as it is pertaining to a Model only, and it clashes with an instance method we explicitly set in the model instances:
https://github.com/rightscale/attributor/blob/master/lib/attributor/types/model.rb#L145-L147

We might be able to get rid of that method or rename (i.e., _attributes) it so it doesn't clash so directly. This would require a lot of care and attention though, as these inheritable types have dependencies on top that might be difficult to bend...

from attributor.

konstantin-dzreev avatar konstantin-dzreev commented on July 17, 2024

It would be nice to have a fix that is not for 'attributes' only but for any method that may overlap with a defined attribute (any method that is defined on a model instance).

from attributor.

blanquer avatar blanquer commented on July 17, 2024

oh absolutely, I simply wanted to point out that this issue is "similar" to #99 , but it is quite different in the sense that has to do with instance-level methods (while #99 is mostly about class-level methods). But either way, a better story for non-overlapping methods would be great regardless.

from attributor.

careo avatar careo commented on July 17, 2024

Duplicate of #71, as that's really how we should end up fixing this.

from attributor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.