Comments (4)
yes, we do have that issue in general (as #99 sort of states).
This particular case of the attributes
method, though, I think is a slightly different, as it is pertaining to a Model
only, and it clashes with an instance method we explicitly set in the model instances:
https://github.com/rightscale/attributor/blob/master/lib/attributor/types/model.rb#L145-L147
We might be able to get rid of that method or rename (i.e., _attributes
) it so it doesn't clash so directly. This would require a lot of care and attention though, as these inheritable types have dependencies on top that might be difficult to bend...
from attributor.
It would be nice to have a fix that is not for 'attributes' only but for any method that may overlap with a defined attribute (any method that is defined on a model instance).
from attributor.
oh absolutely, I simply wanted to point out that this issue is "similar" to #99 , but it is quite different in the sense that has to do with instance-level methods (while #99 is mostly about class-level methods). But either way, a better story for non-overlapping methods would be great regardless.
from attributor.
Duplicate of #71, as that's really how we should end up fixing this.
from attributor.
Related Issues (20)
- Allow a Proc to set the default value of an attribute HOT 2
- Examples with Integer types are not accepted properly
- Default attribute type and options in Attributor model
- Custom metadata for attributes HOT 1
- Support redefining referenced attributes
- Collection validate incorrectly accepts a Hash HOT 1
- An exception during attribute block eval leads to impartially-initialized models with improperly setup attributes.
- Conflict with Hashes with :case_insensitive_load and :allow_extra
- Add Regexp and Class Attributor types for use in app configs
- URI example does not abide by the `:path` option
- Struct/Models do not validate entries using the `requires` DSL
- Add `deprecated` option to attributes
- Make Collection `load` values when adding them into it
- Add description for JSON representation of BigDecimal HOT 1
- Indicate if type instances respond to .dump through `Dumpable` module
- Error running HOT 1
- Add descriptions for types? HOT 1
- Intermittent Attributor::InvalidDefinition when running multi-threaded app under rainbows HOT 1
- Inconsistent coercion for Boolean -> String
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from attributor.