Giter VIP home page Giter VIP logo

Comments (12)

JoviDeCroock avatar JoviDeCroock commented on May 20, 2024 1

Yes, but index.d.ts sorry I misstyped

from playwright-ct.

JoviDeCroock avatar JoviDeCroock commented on May 20, 2024 1

I mean, when someone makes a Pull Request and it gets released 😅

from playwright-ct.

JoviDeCroock avatar JoviDeCroock commented on May 20, 2024 1

Published as 0.1.1

from playwright-ct.

JoviDeCroock avatar JoviDeCroock commented on May 20, 2024

Hey, does it fix itself if you add

{
  "types": "./dist/index.d.mts"
}

to the package json in your node_modules, if so we are missing that field in our package. The new resolution mechanism for newer TS versions is included

from playwright-ct.

chrisha22 avatar chrisha22 commented on May 20, 2024

@JoviDeCroock I was checking the package.json for the node_modules>@preact>playwright-ct and that field is already inside. I tried adding "moduleResolution": "NodeNext" in the ts.config and the error is no longer shown inside the test file import, but it is still appearing inside the playwright-ct.config.ts and also there is like a warning saying that NodeNext is unstable.

from playwright-ct.

JoviDeCroock avatar JoviDeCroock commented on May 20, 2024

It's not their at the first-level, only in the export-map. Mind putting it at the base level as well?

from playwright-ct.

chrisha22 avatar chrisha22 commented on May 20, 2024

I’m sorry @JoviDeCroock I think I'm not following, do you mean adding
{
"types": "./dist/index.d.mts"
}

at the root level of my project's package.json? or where exactly?

from playwright-ct.

JoviDeCroock avatar JoviDeCroock commented on May 20, 2024

Of the package json of our package @preact/playwright-ct it seems to be missing from the latest release so just adding it above this line without nodeNext

from playwright-ct.

chrisha22 avatar chrisha22 commented on May 20, 2024

Like this?

"name": "@preact/playwright-ct",
 "version": "0.0.2",
 "description": "Playwright Component Testing for Preact",
 "repository": "github:preact/playwright-ct",
 "keywords": [
   "Preact",
   "Playwright",
   "testing"
 ],
 "author": "Marvin Hagemeister <[email protected]>",
 "license": "MIT",
 "types": "./dist/index.d.mts",
 "exports": {
   ".": {
     "types": "./dist/index.d.ts",
     "default": "./dist/index.js"
   },
   "./hooks": {
     "types": "./dist/hooks.d.mts",
     "default": "./dist/hooks.mjs"
   }
 },

from playwright-ct.

chrisha22 avatar chrisha22 commented on May 20, 2024

yes, that fixed it!, when is it gonna be available so I can update the package with that change?

from playwright-ct.

chrisha22 avatar chrisha22 commented on May 20, 2024

@JoviDeCroock Since you guys will add the fix for the types Issue in a next version, I'll mark this as resolved, but the problem will still present, I'll be looking forward to get this version as soon as it is available.

Thanks for helping

from playwright-ct.

chrisha22 avatar chrisha22 commented on May 20, 2024

I tried to create a PR with the change so you guys could check it but Unfortunately I couldn’t.

from playwright-ct.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.