Allow better code optimization about preact-compat HOT 8 CLOSED

Hmm - I should think it's at least mildly severable. I wonder - do you think the default export being an Object like that is causing everything to be referenced?

from preact-compat.

Yeah, I reckon it's the default object, but I haven't tried to get rid of that.

In that case another, simpler, approach is to have one file exporting only named functions and then index.js importing from it and exporting again named and default export. That way I can use rollup-plugin-alias to point to the first file letting rollup tree-shake correctly.

I'll let you know tomorrow

from preact-compat.

I've been doing that as well, but then people complained that they couldn't do this when using ES Modules via jsnext:main:

import React from 'preact-compat';

Not sure which way to go. Personally I dislike exporting an identical object as default, it seems a bit odd.

from preact-compat.

@developit #212 suggests a way to keep compatibility and allow tree shaking. Would be great to see if you or anyone else get similar results in terms of bytes saved.

from preact-compat.

@piuccio Curious if you're still wanting to make changes here. I know you were able to shake quite a bit out of preact and preact-compat - does that mean you were able to work around it?

from preact-compat.

Hi, organising the code differently would still allow to save extra bytes, but I'm not obsessed by it anymore. After all preact is not very big to start with.

Do what's more comfortable for you in terms of maintenability, code reading and things like that. I wouldn't be upset if this gets closed and the code stays as it is

from preact-compat.

@piuccio Alrighty. For what it's worth, I'm working on removing as many couplings as possible - previously, Component couldn't be removed because there were type checks that needed a reference to it. Dropping Component means dropping Component.linkState() and a few other things, which might save 500b.

from preact-compat.

I think we can close this out since we ship an ES bundle now.

from preact-compat.