Giter VIP home page Giter VIP logo

Comments (7)

developit avatar developit commented on April 30, 2024 3

Yup, on my to-do list. thx.

from preact.

developit avatar developit commented on April 30, 2024

Interesting. Debugger shows it's attached to the parentNode from <App>, but <App> hasn't yet been appended to the DOM itself. I'd love to avoid deferring componentDidMount(), since that would cost a traversal during render, but that might be the only way. Are you sure React only calls this hook once the whole tree is mounted?

Maybe just a straight up queue would be okay here. It only happens at the root (because render() is special-cased).

from preact.

unindented avatar unindented commented on April 30, 2024

Looks like React only calls the hook once the element is mounted: https://jsfiddle.net/x6xpdkjL/

The docs seem to confirm: https://facebook.github.io/react/docs/component-specs.html#mounting-componentdidmount

from preact.

developit avatar developit commented on April 30, 2024

Awesome, thanks for investigating. I'll try to look into this tonight. I have confirmed the bug is still present in 4.0.1.

from preact.

c2h5oh avatar c2h5oh commented on April 30, 2024

Still present in 4.5.

from preact.

developit avatar developit commented on April 30, 2024

Hooray!! 👏 🎉 🍻

from preact.

developit avatar developit commented on April 30, 2024

Released in 5.2.0-beta.0.

from preact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.