Giter VIP home page Giter VIP logo

Comments (5)

caseybryan avatar caseybryan commented on August 11, 2024

Thank you for the update another publisher found an error in the documentation release notes on
https://github.com/prebid/Prebid.js/releases/tag/0.6.0. It shows the params not in brackets.

Current:
var adUnits = [{
code: '/9968336/header-bid-tag-0',
sizes: [[300, 250], [300, 600]],
bids: [{
accountId: "123", //Required - String id
siteId: "456", //Required - String id
zoneId: "789", //Required - String id
sizes: [15] //optional - array[number] of size key
}]
}];

It should really show:
var adUnits = [{
code: '/9968336/header-bid-tag-0',
sizes: [[300, 250], [300, 600]],
{
bidder: 'rubicon',
params: {
accountId: "1234", //String - required
siteId: "1234", //String - required
zoneId: "1234", //String - required
sizes: [15], //Array[Number] - optional

from prebid.github.io.

caseybryan avatar caseybryan commented on August 11, 2024

I am still seeing Publishers seeing that example and getting errors. Any update on when we can get that removed from: http://prebid.org/dev-docs/getting-started.html

from prebid.github.io.

rmloveland avatar rmloveland commented on August 11, 2024

@mkendall07 if no one else is working on this, I'll take it.

from prebid.github.io.

mkendall07 avatar mkendall07 commented on August 11, 2024

@rmloveland thanks!

from prebid.github.io.

rmloveland avatar rmloveland commented on August 11, 2024

This should be addressed by #31

Note that the (many!) uses of the rp_ Rubicon params in the live examples area of the site will be addressed in #29 -- I wanted to manage the scope on this to at least get something out today.

@caseybryan the examples you referenced should be fixed; please re-open this issue if not.

from prebid.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.