Giter VIP home page Giter VIP logo

Comments (4)

kanzure avatar kanzure commented on May 19, 2024

I strongly disagree with these sorts of section comments:

; ========================= B A N K  3 A =========================

Regarding the other points:

  • tab formatting - do you mean no more tabs? I don't know where else tabs are being used except start-of-line.
  • comments - it would be good to have a gold standard for comments to point to, any recommendations?

from pokecrystal.

Caverns4 avatar Caverns4 commented on May 19, 2024

I would change:
[code]; ========================= B A N K 3 A =========================
[/code]

to something more like
[code]; === Bank 0x3A ===[/code]
But I do feel this is a good thing to do, if nothing else just make things easier to find.

In fact, I would personally like to see things even further subdivided where possible, and have other things merged into bank files. With how important ROM banks are with this processor, each bank might be best split into a file perhaps?

from pokecrystal.

kanzure avatar kanzure commented on May 19, 2024

Yep, 0x3a is much better than 3 A. When a reader searches a file, they are going to be looking for 0x3 or "bank3a" not "bank 3 a".

from pokecrystal.

Caverns4 avatar Caverns4 commented on May 19, 2024

They also might be looking for Bank $3A, since the $ also denotes hex, but 0x3A would be perfectly suitable.

from pokecrystal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.