Giter VIP home page Giter VIP logo

Comments (5)

DingoEatingFuzz avatar DingoEatingFuzz commented on August 15, 2024

I hacked this into my fork of pretender, and we have been using it in our ember acceptance test suite.

Here is the commit: DingoEatingFuzz@3f0fafb

It looks like this.

api.js

this.get('foo/bar', handlerFn);
this.post('foo/bar', handlerFn, true); // async!

test.js

click('.some > button.that.makes.a.post.request');
expect(find('.spinner')).to.exist;
api.resolve('foo/bar');

So when a handler is registered with a third argument, it is used to determine if how it should be handled asynchronously.

If it's a boolean argument
The request will never resolve automatically. It must be resolved manually. Expect a timeout otherwise (this is what the example is using).

If it's a number argument
The request will resolve automatically after n milliseconds. It's just a setTimeout.

I haven't written it in yet, but I would like to take a function as a third argument, then the result of that function would be used to determine the async behavior.

This would solve a problem we have already run into, which is we want things like the login request to resolve automatically except for when we are testing what the app is doing while the login request is doing it's business (such as the spinner assertion above).

Since endpoints are only registered once, functions would allow for responses to be conditionally async.

If you have other thoughts, or want me to hack on this some more, I'm more than happy to. I'd like to contribute 👍

from pretender.

stefanpenner avatar stefanpenner commented on August 15, 2024

I vote is async by default, as that closely resembles reality. Adding configurable timings sounds great too!

from pretender.

trek avatar trek commented on August 15, 2024

I'm down with async as default as well. I've purposely kept things pre 1.0 so I can change this behavior.

from pretender.

DingoEatingFuzz avatar DingoEatingFuzz commented on August 15, 2024

Async as default makes sense to me as well.

from pretender.

trek avatar trek commented on August 15, 2024

Closing in favor of #48

from pretender.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.