Progress events about pretender HOT 8 CLOSED

Any feedback on this?

from pretender.

Still haven't looked. You could speed up the process by providing more details about the pros/cons of this change.

from pretender.

FakeXMLHttpRequest now can send onprogress events. According to the XHR spec, on progress events are triggered each 50ms during downloads and uploads

Usually you don't care about progress event, but sometimes I do. I was thinking in check if the request object has an onprogress event handler attached. If it does means that the user cares about them, and therefore I pretender should fire them regularly.

p.e. in a request with 200ms of delay the event, it would be fired each 50ms. Never before the loadStart and never after the load event.

from pretender.

Sorry for the insistence, but I'm just waiting some green light to start implementing something.

from pretender.

I'd still like to hear the pros/cons. I think you've accurately described the situation, but haven't touched on how it might affect people using the library's current behavior.

from pretender.

I don't think that there is any cons. It's a new feature that should't affect in any form to current users.

The options are
a) Fire the events only if there is a listener for them.
b) Fire the events always.

Intuitively I think that option b) might be simpler to implement and triggering events is cheap enough to not be a concerned about wasting cycles. But in any case it's an implementation detail, the final result for the developer listening for progress events will be identical.

from pretender.

How do you feel about pretender triggering that event each 50ms by default?

Wouldn't we keep triggering events every 50ms, even after a test has finished running, whether you were using them or not? That seems like a high likelihood of ending up with test leaks?

from pretender.

@trek see #73 for the implementation details. The change is fairly minimal and I don't see any posibility of leaking since the next progress event is scheduled only if the request is still ongoing.

from pretender.