Giter VIP home page Giter VIP logo

Comments (1)

boqiaok avatar boqiaok commented on May 26, 2024

I found my problem, the 'EventHandlers.events.indicator' is not removed again after the dragend

1: get 'EventHandlers.events.indicator'
2: But dragend not set 'events.indicator = null', this leads to the next time old will exist

private dropElement(
  onDropNode: (
    draggedElement: DraggedElement,
    placement: Indicator["placement"]
  ) => void
) {
  const events = EventHandlers.events; // 1
  if (
    EventHandlers.draggedElement &&
    events.indicator &&
    !events.indicator.error
  ) {
    const { placement } = events.indicator;
    onDropNode(EventHandlers.draggedElement, placement);
  }

  if (EventHandlers.draggedElementShadow) {
    EventHandlers.draggedElementShadow.parentNode.removeChild(
      EventHandlers.draggedElementShadow
    );
    EventHandlers.draggedElementShadow = null;
  }

  EventHandlers.draggedElement = null;
  this.store.actions.setIndicator(null); // 2
  // EventHandlers.events.indicator = null // 3 remove old
  thais.store.actions.setNodeEvent("dragged", null);
}

from craft.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.