Giter VIP home page Giter VIP logo

Comments (3)

ashygee avatar ashygee commented on May 4, 2024

@rezrah I think the size prop feels weird that the values are separate from the values on the scale. If we use scale values could we use 400, 500, 800 etc.? Or even, use the pixel size values that we're going to be applying in Primer Primitives?

from brand.

rezrah avatar rezrah commented on May 4, 2024

@ashygee yes totally. I recall a conversation about the hundred naming convention being confusing, which is why I did it this way? Effectively the only options are 1-6.. which correspond to the default sizing or h1-h6. I can definitely move it over to that scale, but it does feel more abstract to me and requires assumed knowledge of that scale.

from brand.

ashygee avatar ashygee commented on May 4, 2024

@rezrah and I discussed this and I completely understand the single digits now. the number refers to the heading level size to be rendered. Therefore size="3" = the size used by default in an H3 (previously rendered in CSS with .h3-mktg)

from brand.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.