Comments (6)
We can safely ignore the size recommendation and use our defined sizing scale instead. This way, we keep things predictable, maintain good visual rhythm and consistent alignment with the surrounding elements. The Instagram glyph is perfectly legible at 24px
.
Fun fact: Meta uses the Instagram glyph at 21px
on their own website.
from brand.
Im in agreement with this @JoshBowdenConcepts 👍 .
from brand.
Can we keep all the icons at 24px
? Making all of them at 29px
makes the logo area unbalanced.
- The 29px makes sense with Instagram but is arbitrary with our patterns.
Octicons
for instance has its bigger size at24px
: https://primer.style/design/components/icon#sizes - We already increased the size compared to the ones in dotcom, which uses
22px
, so the difference will be bigger.
Actual glyph size at 24px:
Glyph size at 29px:
from brand.
Thank you all for your feedback!
@JoshBowdenConcepts we'd like to go with @danielguillan and @josepmartins recommendation and keep all the icons at 24px
👍🏽
from brand.
@rezrah @raytalks just because this was on my mind this addition does follow the Instagram guidelines mostly except for the following issue.
- A minimum size ensures that the impact and legibility of the glyph are not compromised in the application. Always maintain their set proportions and never show the glyph smaller than 29x29 pixels.
We could solve this by increasing the size of the glyphs for all our icons at this time. Would this be a viable solution or should we reach out to design? Currently, our Icons are sitting around 24px so this would not be that large of a change.
from brand.
Great question, I'd like to check with design.
@ajashams do you know?
from brand.
Related Issues (20)
- 🐛 [BUG] - Animating hero (above the fold) HOT 2
- [Accessibility] Improve `SubdomainNavBar` keyboard navigation
- [Accessibility] After resizing page to 320*256 focus moving to the hidden elements while navigating with the tab key. HOT 3
- [Accessibility] Visual name and aria-label are different for 'GitHub' control HOT 1
- [Accessibility] Add a "Skip To Content" button to `SubdomainNavBar` HOT 4
- [Accessibility] Improve overflowing of `SubdomainNavBar` on mobile
- Prose: support additional HTML tags HOT 2
- Missing `Animation.module.css` in the build and published artifact HOT 2
- Logo suite with many logos + reduced motion HOT 2
- Add support for directional border to Box
- 🐛 [BUG] - Spacing on River Breakout HOT 3
- [Feature request] Add support for other fonts
- 🐛 [BUG] - FAQ Item click area overlaps with FAQ Anser
- 🐛 [BUG] - InlineLink does not inherit size HOT 7
- [Feature request] Add support for multiple `AnchorNav.Action` HOT 3
- 🐛 [BUG] - `Prose`'s unordered lists do not play well with dark mode
- [Suggestion]: Add documentation around Stack breakpoints
- 🐛 [BUG] - Regression of `leadingVisual` on `TextInput` HOT 1
- 🐛 [BUG] - Button Gap on Medium Size should be 4px (0.25rem) instead of 12px. HOT 5
- [Feature request] Allow `<Label>` in River + Bentos HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brand.