Giter VIP home page Giter VIP logo

Comments (6)

danielguillan avatar danielguillan commented on May 4, 2024 3

We can safely ignore the size recommendation and use our defined sizing scale instead. This way, we keep things predictable, maintain good visual rhythm and consistent alignment with the surrounding elements. The Instagram glyph is perfectly legible at 24px.

Fun fact: Meta uses the Instagram glyph at 21px on their own website.

from brand.

ajashams avatar ajashams commented on May 4, 2024 1

Im in agreement with this @JoshBowdenConcepts 👍 .

from brand.

josepmartins avatar josepmartins commented on May 4, 2024 1

Can we keep all the icons at 24px? Making all of them at 29px makes the logo area unbalanced.

  • The 29px makes sense with Instagram but is arbitrary with our patterns. Octicons for instance has its bigger size at 24px: https://primer.style/design/components/icon#sizes
  • We already increased the size compared to the ones in dotcom, which uses 22px, so the difference will be bigger.

Actual glyph size at 24px:

Glyph size at 29px:

from brand.

raytalks avatar raytalks commented on May 4, 2024 1

Thank you all for your feedback!
@JoshBowdenConcepts we'd like to go with @danielguillan and @josepmartins recommendation and keep all the icons at 24px 👍🏽

from brand.

JoshBowdenConcepts avatar JoshBowdenConcepts commented on May 4, 2024

@rezrah @raytalks just because this was on my mind this addition does follow the Instagram guidelines mostly except for the following issue.

  • A minimum size ensures that the impact and legibility of the glyph are not compromised in the application. Always maintain their set proportions and never show the glyph smaller than 29x29 pixels.

We could solve this by increasing the size of the glyphs for all our icons at this time. Would this be a viable solution or should we reach out to design? Currently, our Icons are sitting around 24px so this would not be that large of a change.

from brand.

raytalks avatar raytalks commented on May 4, 2024

Great question, I'd like to check with design.
@ajashams do you know?

from brand.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.