Comments (1)
rezrah
commented on May 4, 2024
Thanks @rfearing.. on the specificity issue...
We should...
- Enable our primer linters for CSS modules
- Convert the img and video default selector to a class name, which will enable normal overriding
On align prop, I agree it would feel like a more composable API, but there are reasons why it's this way. Having an align prop will help us infer reading direction for localisation. The DOM nodes themselves are also ordered using this mechanism. Also in a bid to 'sync' our React API to the Figma component, where we need to have an 'align' prop.
If this prop isn't causing major issues right now, I'd recommend we add it to the backlog as a separate Issue so we can circle back to it at the end of the quarter.
from brand.
Related Issues (20)
- 🐛 [BUG] - InlineLink does not inherit size HOT 7
- [Feature request] Add support for multiple `AnchorNav.Action` HOT 3
- 🐛 [BUG] - `Prose`'s unordered lists do not play well with dark mode
- [Suggestion]: Add documentation around Stack breakpoints
- 🐛 [BUG] - Regression of `leadingVisual` on `TextInput` HOT 1
- 🐛 [BUG] - Button Gap on Medium Size should be 4px (0.25rem) instead of 12px. HOT 5
- [Feature request] Allow `<Label>` in River + Bentos HOT 1
- 🐛 [BUG] - `padding-inline-start` does not set in Timeline.Item component HOT 2
- [Accessibility] `SubdomainNavBar` misses controls when narrow HOT 3
- [Accessibility] `FAQ.Item` is not getting closed using 'ESC' key
- [Contentful] Add Possibility of Content Block (Rich Text) Modules HOT 2
- 🐛 [BUG] - `Testimonial`: insufficient contrast for default quote symbol in dark mode HOT 1
- [Suggestion] Enhance the `Heading` component to support new `text-wrap` values HOT 3
- [Feature request] Allow custom icon in `UnorderedList.Item` HOT 1
- 🐛 [BUG] - `className` is missing on `<Hero.Description>`
- [Suggestion] Update the example for the `ActionMenu`
- 🐛 [BUG] - Action menu overlay for adding language dropdown HOT 1
- [Feature request] Support smaller Bento icon size HOT 1
- [Accessibility] No error state or error description in Forms HOT 1
- Increase height of snapshots
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brand.