Giter VIP home page Giter VIP logo

Comments (11)

yaili avatar yaili commented on May 4, 2024

To keep things simple, the best solution is probably to use the existing alert style. Thoughts?

🎨 Figma WIP

cc @ashygee @broccolini @emplums

from doctocat.

colebemis avatar colebemis commented on May 4, 2024

Over the summer, we had played around with the idea of a note/alert component similar to this:

image
https://theme-ui.com/getting-started

from doctocat.

colebemis avatar colebemis commented on May 4, 2024

We also discussed having different colors to represent different types of "alerts." Specifically, we discussed blue for information, yellow for warnings, and pink for protips.

from doctocat.

yaili avatar yaili commented on May 4, 2024

I guess alerts works the same way, except pink is for errors.

from doctocat.

emplums avatar emplums commented on May 4, 2024

I was reading some Figma documentation today and really liked their note component:

image

https://help.figma.com/hc/en-us/articles/360039823654-Download-the-Figma-Desktop-App

from doctocat.

yaili avatar yaili commented on May 4, 2024

Looks cool.

They also seem to have different types of notes:
Screenshot 2020-02-11 at 19 00 34
https://help.figma.com/hc/en-us/articles/360039829154-Receive-Comment-Notifications-in-Slack

Screenshot 2020-02-11 at 19 01 01

https://help.figma.com/hc/en-us/articles/360039829254-ProtoPie-and-Figma

And guessing this is the default box style:
Screenshot 2020-02-11 at 19 01 47
https://help.figma.com/hc/en-us/articles/360039829154-Receive-Comment-Notifications-in-Slack

from doctocat.

emplums avatar emplums commented on May 4, 2024

Yeah! This style might be too bold for GitHub but I do like that it really stands out on the page and feels kinda slick. I think we could use something outside of the design system though for these notes since they do have a pretty specific purpose that differs from how we use Alerts in .com

from doctocat.

emplums avatar emplums commented on May 4, 2024

Latest design here: https://www.figma.com/file/qsKUZDH4xE8h6e7p7GBE8e/Doctocat-Extra-components?node-id=291%3A0

image

from doctocat.

colebemis avatar colebemis commented on May 4, 2024

@yaili What different types of alerts do we want to support? It'd be helpful if we could list them all out and assign them colors.

from doctocat.

yaili avatar yaili commented on May 4, 2024

@colebemis I think we'd have a warning/danger, alert, tip, and default (the blue one, Figma Docs calls it "note").

Would we want to align with names of our Primer components?

from doctocat.

colebemis avatar colebemis commented on May 4, 2024

Closed by #167

from doctocat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.