Comments (3)
Quick design feedback:
- It doesn't seem to be lined up with anything vertically, and generally seems like odd positioning
- It seems too close to the content, perhaps should be flush right, or in a box or something so doesn't look so floaty
- It also looks like we've made the page width smaller which I think is a mistake, we should make it wider if we put in the same container as the content lets make it wider to be the same width as before.
Mobile also needs some work. The Chevron should be facing down, same as in the global mobile nav. Something about this just feels off too, maybe resolved by style updates to desktop version if you add a box, or maybe just needs to be blue or something.
from doctocat.
Some thoughts:
- I understand the position of the ToC aligned with the top of the first paragraph, as that's where it moves to in small screen, but I agree it would look better if we align with the page title
- Could we make the ToC text 14px instead? I think that would clarify the hierarchy/importance of the ToC in relation to the main content, and it may help with creating visual distance from the main content
- I agree with the suggestion to make the page width wider so the main content has the same width as before
- Should we revert to the caret instead of chevron, in small screen?
- Can we add an indicator of where in the page we are? In the designs (see 🖼⬇️) I had an orange indicator, but happy with something else if it's easier/more in line with existing examples
from doctocat.
Closed by #166
from doctocat.
Related Issues (20)
- Standardized examples in Doctocat HOT 1
- Border radius not present in example iframes
- background color error HOT 1
- Stale instructions HOT 2
- Add frontmatter variable to hide "Edit this page" links HOT 2
- Bump @primer/components to the latest version
- Implement `groupBy` functionality for checklists
- Add a built-in component maturity checklist
- Move away from deprecated @primer/react components
- Intermediate breakpoints causes the layout to break on pages with large snippets HOT 1
- Update doctocat to support React 18 HOT 1
- [Feature request] Do not hardcode the word `Primer` in the header component. HOT 1
- [Feature request] Allow customization of the "Edit on GitHub" links HOT 1
- [Feature request] A search page with all results listed HOT 1
- Build output SSRProvider warnings
- Accessibility analysis HOT 1
- Duplicated heading texts should have a unique ID to generate expected anchor link HOT 13
- Add a Dark/Light theme toggle button to the navbar HOT 4
- Test
- Documentation content vertical spacing HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from doctocat.