Giter VIP home page Giter VIP logo

Comments (9)

github-actions avatar github-actions commented on July 16, 2024

Uh oh! @DavidMeu, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

from react.

patrickhlauke avatar patrickhlauke commented on July 16, 2024

Not an expert on this, but I think the idea is that you'd leverage the onOpenChange property on the ActionMenu, rather than trying to catch the click on the button itself (which already has the behaviour attached to it to open/close the menu).

from react.

DavidMeu avatar DavidMeu commented on July 16, 2024

Not an expert on this, but I think the idea is that you'd leverage the onOpenChange property on the ActionMenu, rather than trying to catch the click on the button itself (which already has the behaviour attached to it to open/close the menu).

I see what you are saying.
The thing is I just need a simple onClick and I don't want to recreate this state just to overload my method.

from react.

siddharthkp avatar siddharthkp commented on July 16, 2024

Hey! Can confirm that the onClick is overwritten. Can classify as bug.

Out of curiosity, what are you planning to do in the onClick handler?

from react.

DavidMeu avatar DavidMeu commented on July 16, 2024

Hey! Can confirm that the onClick is overwritten. Can classify as bug.

Out of curiosity, what are you planning to do in the onClick handler?

I want to trigger a check to filter out options from the dropdown.

from react.

siddharthkp avatar siddharthkp commented on July 16, 2024

I want to trigger a check to filter out options from the dropdown.

That's interesting, can you share more? (Note: This repository is open source. If the context is unreleased/sensitive, please share it on slack #primer instead)

from react.

siddharthkp avatar siddharthkp commented on July 16, 2024

👋 @DavidMeu, this came up in the prioritisation call today. Can I get some context around what you are working on, that will help us if we need to prioritise a fix or recommend the workaround Patrick mentioned.

from react.

DavidMeu avatar DavidMeu commented on July 16, 2024

👋 @DavidMeu, this came up in the prioritisation call today. Can I get some context around what you are working on, that will help us if we need to prioritise a fix or recommend the workaround Patrick mentioned.

This is part of devportal pipeline runs.
Recently Heaven UI got deprecated and devportal will replace it by the end of the quarter.
Here is the official release post.

from react.

siddharthkp avatar siddharthkp commented on July 16, 2024

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.