Fix a11y build warnings about primo HOT 5 CLOSED

I understand what you said.
I will proceed to fix this issue in that direction.
Thanks for the advice.

from primo.

If you don't mind, I'd like to be in charge to this issue !

from primo.

Definitely! Let me know if you run into any issues

from primo.

@mateomorris
Thank you for your replay !

They'll all need to be changed to this:

// const uid = getUniqueId()  
<label for="{uid}" />
<input id="{uid}" />

Would it be preferable not to nest like this example?
Like here, for example.
https://github.com/primo-app/primo/blob/2c25dc7a721895555ec355b91d28226581dca23f/src/components/inputs/TextInput.svelte#L24
Or do I just add for property to label tag and id property to input tag?

from primo.

Actually, now that I look into it it looks like it's valid to nest the input inside the label (as long as the input isn't a button). https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

So actually, it would be best if you left them nested and instead applied the the Svelte ignore-a11y-warning comments so the compile warnings stop showing up. Make sense?

from primo.