Comments (5)
I understand what you said.
I will proceed to fix this issue in that direction.
Thanks for the advice.
from primo.
If you don't mind, I'd like to be in charge to this issue !
from primo.
Definitely! Let me know if you run into any issues
from primo.
@mateomorris
Thank you for your replay !
They'll all need to be changed to this:
// const uid = getUniqueId() <label for="{uid}" /> <input id="{uid}" />
Would it be preferable not to nest like this example?
Like here, for example.
https://github.com/primo-app/primo/blob/2c25dc7a721895555ec355b91d28226581dca23f/src/components/inputs/TextInput.svelte#L24
Or do I just add for property
to label tag
and id property
to input tag
?
from primo.
Actually, now that I look into it it looks like it's valid to nest the input inside the label (as long as the input isn't a button). https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
So actually, it would be best if you left them nested and instead applied the the Svelte ignore-a11y-warning comments so the compile warnings stop showing up. Make sense?
from primo.
Related Issues (20)
- Improvements HOT 2
- PLEASE HELP: Error: Cannot import "@iconify/svelte/dist/Icon.svelte": no matched export path was found in "pkg_name/package.json". HOT 2
- Error when deploying site on vercel HOT 2
- Markdown styles HOT 4
- error when integrating collaborators HOT 6
- Add Ability to Make Image Fields Language Independent
- Scroll blocked while pointer is over image
- Svelte Video Component HOT 2
- Missing catch/finally block in the server-side compilation, beta v46 HOT 2
- Cannot edit "Join us on our mission" block
- Primo blocks doesn't load HOT 1
- Cannot create site with the same URL as an already-existing site
- Duplicate button does not work HOT 2
- Conditional fields HOT 1
- Fighting the browser cache in deployed websites
- Draggable fields
- site footer icons getting errors @iconify/svelte cannot be built HOT 3
- Unable to deploy a website made through Primo. HOT 3
- Collaborator Enhancements
- deploying to github repo removes CNAME file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primo.