Giter VIP home page Giter VIP logo

Comments (15)

rom1504 avatar rom1504 commented on June 23, 2024

Actually I don't think we need displayName and it's a bit annoying to get.

from minecraft-data.

Darthfett avatar Darthfett commented on June 23, 2024

/Darthfett/helperbot I believe would need displayName to lookup blocks and items. It would be good to provide the same API here, if any projects end up needing it for entities. For example, a bot that tells you how many entities are in range (and their names).

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

Why would you need the displayName ? Isn't the name enough ?
(5th column vs 6th column of http://minecraft.gamepedia.com/Data_values/Entity_IDs)

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

isn't this enough https://github.com/PrismarineJS/minecraft-data/blob/master/enums/entities.json ?

from minecraft-data.

Darthfett avatar Darthfett commented on June 23, 2024

I'm not even sure the original proposal would work. It looks like the
Wither Skeletons and Skeletons are grouped as one type of entity.
On Apr 1, 2015 11:21 AM, "Romain Beaumont" [email protected] wrote:

isn't this enough
https://github.com/PrismarineJS/minecraft-data/blob/master/enums/entities.json
?


Reply to this email directly or view it on GitHub
#11 (comment)
.

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

Well they have the same id

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

I'm not saying this is perfect, but it's still much better than the current mineflayer thing (https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/entities.js#L28)

I don't know how the game knows the difference between Wither Skeletons and Skeletons

from minecraft-data.

Darthfett avatar Darthfett commented on June 23, 2024

Sounds like a similar problem as the one we are solving with blocks. Do
entities have metadata too? Maybe we can use a similar solution as the one
we use for blocks.

Well they have the same id


Reply to this email directly or view it on GitHub
#11 (comment)
.

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

Hmm I don't think they have metadata (https://github.com/andrewrk/mineflayer/blob/master/lib/entity.js), maybe it's just the equipment they wear ?

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

ok maybe entities have metadata https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/protocol.js#L141

the value is not in the wiki though, so I'm going to ignore it for now (at least until we know something about it)

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

some info about the metadata http://wiki.vg/Entities#Skeleton

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

many kinds of spawn_* https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/protocol.js#L156 , what's an "entity" ?

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

I added displayName in the end. I think this file is in a decent enough state to be used in mineflayer. Metadata information can be added afterwards (probably when it's done for items and blocks)

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

I don't know if we really want to put metadata in that file. There's just the skeleton that has a simple variation.
The rest is all functional metadata that I'm not sure at all should be in that .json (see http://wiki.vg/Entities#Entity_Metadata)

from minecraft-data.

rom1504 avatar rom1504 commented on June 23, 2024

So yeah indeed, entity metadata is a functional thing. It should be handle case by case in mineflayer code, not in entities.json.

File now integrated in mineflayer !

from minecraft-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.