Giter VIP home page Giter VIP logo

Comments (12)

rom1504 avatar rom1504 commented on July 22, 2024

I'm okay with that (it's even automatically extractable from the wiki : see drops in the infobox in http://minecraft.gamepedia.com/Stone).
The tool you need to use is an other field (harvestTools : https://github.com/PrismarineJS/minecraft-data/blob/master/enums/blocks.json#L20 : should probably be an array instead of a "id":true object).

Why minAmount and maxAmount though ? Isn't amount enough ?

from minecraft-data.

roblabla avatar roblabla commented on July 22, 2024

Glowstone, lapis, etc... both have random amount of drops.

from minecraft-data.

Gjum avatar Gjum commented on July 22, 2024

This could also be done for entities.

from minecraft-data.

rom1504 avatar rom1504 commented on July 22, 2024

Oh right, yeah.

from minecraft-data.

rom1504 avatar rom1504 commented on July 22, 2024

Tools drop all drop the same thing (or nothing) for one given block, except for tools with enchantments :

  • silk : maybe store what you can harvest with silk in a silk.json
  • fortune

Enchantments (http://minecraft.gamepedia.com/Enchant#Enchantments) should probably be handled separately.

from minecraft-data.

Gjum avatar Gjum commented on July 22, 2024

There is a lot of minCount: 1, maxCount: 1 - should we allow a simple count: 1 if min == max?

from minecraft-data.

rom1504 avatar rom1504 commented on July 22, 2024

Yeah I guess.
Oh and I took the "chance" from the wiki when it was available, so minCount can be a number from 0 to 1 (for exemple 0.3333 for 33.33%), I don't know if it that's a good idea.

from minecraft-data.

roblabla avatar roblabla commented on July 22, 2024

chance might be useful for servers to implement the dropping behavior ;)

from minecraft-data.

rom1504 avatar rom1504 commented on July 22, 2024

So : there are a lot of minCount: x, maxCount: y with x==y, we can add a count: field. Because often x==y==1, it might also be possible to not put a count at all for these ? (default : count = 1)

from minecraft-data.

roblabla avatar roblabla commented on July 22, 2024

Wouldn't it be better to keep data difference to a minimum ? I feel having either min/max OR count would make it harder to use the minecraft-data without really adding value.

from minecraft-data.

rom1504 avatar rom1504 commented on July 22, 2024

Yeah I agree.
What about having the default value for both these fields to 1 so in most cases they just wouln't be there ?

from minecraft-data.

roblabla avatar roblabla commented on July 22, 2024

Yeah, default values are perfectly fine.

from minecraft-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.