New recipe format about minecraft-data HOT 26 CLOSED

check it isn't too ugly

Any ideas how to do this?

from minecraft-data.

I think trying to apply the new format to several recipes in recipes.json might give a good idea if the format is good. For example :

• some recipes that are correctly handled by the old format : see if they stay readable
  • recipes with inShape
  • recipes with ingredients
  • recipes with outShape
• some recipes that are not handled by the old format

from minecraft-data.

Hm, I tried to do that with the example at the bottom.
Updated it with a 1x1 and 1x2 shape.

Also writing the spock implementation now, nearly done.

from minecraft-data.

Oh yeah right. Looks good.
I'm not sure about one thing though :
is

{ // Polished Granite
            "result": {"id": 1, "meta": 2, "amount": 4},
            "inShape": [
                [[1,1], [1,1]],
                [[1,1], [1,1]]
            ]
        },

better or :

{ // Polished Granite
            "result": {"id": 1, "meta": 2, "amount": 4},
            "inShape": [
                [{"id":1, "meta":1}, {"id":1, "meta":1}],
                [{"id":1, "meta":1}, {"id":1, "meta":1}],
            ]
        },

the array is a bit confusing I think (since we also have array of ids in that file)

from minecraft-data.

I prefer the first one, personally.

from minecraft-data.

First one is shorter and more human-friendly, although support for both is trivial.

from minecraft-data.

Ok let's keep the first one then.

from minecraft-data.

what about repairing a tools?
http://minecraft.gamepedia.com/Repair

from minecraft-data.

Not sure if that should be included, as an entry per tool and damage value would be the only way with the current format.
I think handling this on a higher level would be better, as this can be easily expressed in code, but not in data.

from minecraft-data.

Yeah I don't think this is a recipe. It's not crafting either.

The "recipe" is even simple to figure out ("Two items of the same type and material can be placed anywhere on the crafting grid, and the result is a single repaired item").

Maybe the data in the tables in that Repair page would be useful for the implementation but that would be in a different .json.

from minecraft-data.

Python utils for Spock: Done!
Feel free to modify for mineflayer.

from minecraft-data.

I'm thinking about building a converter from old to new format, just for testing, as long as the wiki scripts are not ready.

from minecraft-data.

Converter done! See #4

from minecraft-data.

Ok, I've done a schema for the old recipes format, I'm going to do one for the new schema too I think.

from minecraft-data.

The schema for the new recipe format is done, see http://prismarinejs.github.io/minecraft-data/

from minecraft-data.

I added a link to the README to the wiki page of the new recipe format.

I wonder if that page should stay in the wiki or be added as a .md file in the doc/ folder ?

from minecraft-data.

For documents that won't change often, doc/*.md is better than wiki IMO. I only use the wiki when drafting.

from minecraft-data.

👍 for doc/*.md. Wiki is cool for quick collaboration, but it quickly becomes hard to navigate;

from minecraft-data.

Ok I'll put it there, once I checked everything is ok with the format by doing the last two points (implementing in mineflayer and updating my wiki extractors scripts)

from minecraft-data.

Implemented in mineflayer. Now the only thing remaining here is updating the wiki scripts.

from minecraft-data.

Ok, problem :
we don't have the "Smooth Granite" --> [1,1] data anywhere, I can't update the recipe without that info.

I think we're going to need to scrape the wiki in the end

from minecraft-data.

Is it really called Smooth Granite and not Polished?

from minecraft-data.

Yeah I think it's Polished Granite, my confusion came from there https://github.com/PrismarineJS/minecraft-data/wiki/Proposed-new-recipe-format#metadata-in-the-shapes

from minecraft-data.

So, the last step of that issue depends on #7 and then on #8 . it won't be closed very soon.

from minecraft-data.

We are using the new recipe format now, and the remaining problems are all covered with issues. So this can actually be closed.

from minecraft-data.

Yeah you're right.

from minecraft-data.