Comments (5)
an alternative to this would be putting back a master branch with just the extractors, the README, and have the readme link to the version branches. IDK which is better, a part of me likes the way things are organized right now, but it does incur some maintenance overhead.
from minecraft-data.
#65 (comment) convinces me even more that the wiki extractor really shouldn't be in minecraft-data.
Their output format is mcData schema yes, but apart from that they are independant from minecraft-data. I think I might try putting them in a separate repo, what would be nice about that is treating these extractors as really a first class package, and doing things like automatically following the wiki changes and having that "wiki watcher" bot do PR to minecraft-data or something.
I also thinks that extractors shouldn't be in a big "all-minecraft-extractors-in-every-language-from-every-source" repo, but instead just one repo by kind of extractor (for example burger is its own repo, PocketBurger too, and I think my wiki extractors should be in their own repo, and I guess a repo for the (small) decompiled extractor I did would make sense). That way everybody is free to make his own extractor in whatever language he likes from whatever source and PR his results to mcData.
About a master branch : a possibility would be having everything but the data (the schema, the auto-testing, (possibly the extractors if they stay there), the readme) in master. And version branches would just contain the data (the .json files).
It would probably mean submoduling these version branches in master which has pros (no need to do this in each X-minecraft-data) and cons (need to update the submodule often to check the data fits the schema). Other ways than submoduling can be considered (in order to check the schemas for example).
The general idea here is to separate things that are independent and to do as little copy pasting (~= cherry-pick) as possible.
from minecraft-data.
I really think the extractors should be in the minecraft-data repo. It allows anyone to easily see how the data was generated, and easily find the tools to generate it themselves. The alternative, putting links to all the tools, is OK, but we need to make sure we keep that list up to date,
from minecraft-data.
So, I did everything in this issue: put the extractors in different repos (listed in the readme) and put everything in master branch to avoid duplication.
I changed everything on projects that depend on minecraft-data (directly in nmd and pmd and via PR in ProtocolGen and phase_bot)
I'll let 1.8 and 1.9 branches live for a little while more, so phase_bot can merge the pr and other potential users can use master and then I'll delete them.
I'll close this issue then.
from minecraft-data.
done
from minecraft-data.
Related Issues (20)
- Does this repository contain any pngs linked of any sort? HOT 1
- Review and fix protocol.json for 1.20.2 HOT 5
- blockMappings.json only available in v1.19.1?
- [1.20.2] Incorrect recipes, and inconsistent shape format HOT 2
- Support Minecraft PC 1.20.3 HOT 2
- Support Minecraft PC 1.20.4 HOT 1
- Several 1.20.2 recipes have invalid shape data (PC) HOT 2
- Create gh action bot to diff protocol files HOT 1
- 1.20.2 and 1.20.3 missing metadataKeys in entities.json. HOT 8
- Add sound id - sound name map for each version HOT 10
- Add blocks & items pc renames data HOT 1
- Add version: HOT 1
- Add version:
- Identifcation of experimental features/items? HOT 4
- why are the block IDs in this package different from the actual minecraft block IDs? HOT 2
- How can find the description for switches? HOT 4
- Issue with Block State (blocksB2J.json and blocksJ2B.json) Data in Version 1.20.30
- Tb
- Add version:
- Support Minecraft PC 1.20.5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minecraft-data.