Supporting several protocol versions about minecraft-data HOT 6 CLOSED

I think different branches would probably be the best, so we can backport thing more easily.

from minecraft-data.

How would different branches work on NPM, would there be separate modules minecraft-data-1.8, minecraft-data-1.7, etc., or different major versions of https://www.npmjs.com/package/minecraft-data?

If the latter, this could cause problems with cross-protocol support; since package.json "dependencies" is keyed by module name so only one minecraft-data module could be listed in each package.json. (Though I suppose this could be worked around in the dependent module by creating separate directories with different package.json's adding each specific minecraft-data module version.)

from minecraft-data.

creating separate directories with different package.json's adding each specific minecraft-data module version

yeah this would probably be the plan (because a dependent module might want to support multiple version at the same time ( @roblabla would like to do that in node-minecraft-protocol (when he's done Protocols and node-minecraft-protocol is mainly a .json that can be added to minecraft-data)))
So I guess different major versions.

from minecraft-data.

see PrismarineJS/node-minecraft-data#4

from minecraft-data.

What has been done here :

• a branch for each mc version (currently 1.8 and 1.9)
• no master branch

Next step is fixing PrismarineJS/node-minecraft-data#4

from minecraft-data.

done

from minecraft-data.