Rewrite the code to Task base asynchronous pattern about prism-samples-wpf HOT 8 CLOSED

You are right, need to get that updated. Hopefully someone from the community who it bothers will step in and submit a pull request with those fixes (hint hint) :)

Seriously though, please do if you have time. We'll keep this in the backlog if not and try to get to it when we can.

from prism-samples-wpf.

OK, may be I will do it.

from prism-samples-wpf.

I did it, and I'm trying to send a pull request but I get a message that i don't have permissions.

from prism-samples-wpf.

I suppose you did commit to your own fork and not this repository? As others can send a PR, I think everything permission-wise should be ok (unless one of the brians changed it lately).

from prism-samples-wpf.

No changes that I am aware of.

So did you get your changes checked in to your own fork and push'ed up to GitHub? Is the error happening when you press the "Compare, Review and Create a Pull Request" green button to the upper left of the list of files in your fork?

If you can give some more information we can try to help you through it. Or if you just want to send me a zip of what you have I can get it checked in for you but will still need you to sign a CLA:
https://cla2.dotnetfoundation.org/

Thanks
Brian

from prism-samples-wpf.

I hope I did everything right ..

YehudahA#1

from prism-samples-wpf.

Your pull request was under your own repo, not the Prism one. There were a number of changes I would have made to it anyway, so just went and updated the sample myself.

from prism-samples-wpf.

OK, a good job, but some comments:

• I think that using ObservableCollection as Notify-property is anti-pattern.
  Instead of:

        public ObservableCollection<Meeting> Meetings
        {
            get { return meetings; }
            set { SetProperty(ref meetings, value); }
        }

Instead of this, we can use List<Meeting>, or like you did in ContactsViewModel: mettings.ForEach ....

But in my opinion, the best way to initialize collection is using extension method:

using System.Collections.Generic;
using System.Collections.ObjectModel;

namespace ViewSwitchingNavigation.Infrastructure
{
    public static class ObservableCollectionExtensions
    {
        public static void AddRange<T> (this ObservableCollection<T> targetCollection,IEnumerable<T> source)
        {
            foreach(T item in source)
            {
                targetCollection.Add(item);
            }
        }
    }
}

//====================//
Instead of:

            contactsServiceMock
                .Setup(svc => svc.GetContactsAsync())
                .Returns(Task.FromResult(contacts));

You can write:

            contactsServiceMock
                .Setup(svc => svc.GetContactsAsync())
                .ReturnsAsync(contacts);

from prism-samples-wpf.