Fix benchmarks about zkevm-circuits HOT 3 CLOSED

Assign this task to @zemse

from zkevm-circuits.

Since StateCircuit uses the U16 table, it seems to me that the degree should have to be at least 16. Should the fix simply add a minimum default value for the DEGREE env similar to other tests?

How are the benchmark tests triggered? Is it run individually passing in the DEGREE manually or using cargo test inside circuit-benchmarks?

circuit-benchmarks $ cargo test --features=benches

from zkevm-circuits.

Since StateCircuit uses the U16 table, it seems to me that the degree should have to be at least 16. Should the fix simply add a minimum default value for the DEGREE env similar to other tests?

That makes sense. Your suggestion would be a possible solution. Another solution that comes to my mind is to just check if DEGREE is >= 16 for the StateCircuit benchmark, and if not panic early with a message. Also the same process should be done for the other benchmakrs: check if the other circuits have a minimum degree, and either panic with a useful message when degree is lower, and/or set a default degree that is the minimum.

How are the benchmark tests triggered? Is it run individually passing in the DEGREE manually or using cargo test inside circuit-benchmarks?

circuit-benchmarks $ cargo test --features=benches

You can trigger them with this command from the circuit-benchmarks directory:

DEGREE=10 cargo test --features=benches state_circuit::tests

You can replace state_circuit by any of the implemented benchmarks which are:

• bytecode_circuit
• copy_circuit
• evm_circuit
• exp_circuit
• mpt_circuit
• packed_multi_keccak
• pi_circuit
• state_circuit
• super_circuit
• tx_circuit

from zkevm-circuits.