Comments (4)
Re-opening as esbuild v0.11.15 has an option to remove comments.
from esbuild-loader.
This is by design on esbuild's end:
And all comments other than license-related comments are stripped out by esbuild anyway.
Can you open an issue here?
I think minification-benchmarks can also benefit from a more nuanced control over removing comments as other minifiers support it.
from esbuild-loader.
I would still open a feature request about having granular control over whether license comments should be kept. Some authors might be referencing licenses in a separate file instead of the JS code.
Since esbuild preserves @license
comments, you can try removing it to trick esbuild into thinking it's an ordinary comment.
As an example, you can use code-inject-loader to accomplish this:
{
loader: 'code-inject-loader',
options: {
transform: src => src.replace(/@license/, '')
}
},
{
loader: 'esbuild-loader',
...
}
Note that this is risky because it doesn't guarantee that @license
is used as a part of a comment.
from esbuild-loader.
Thanks for the reference 👍
Edit:
I believe it has been answered here evanw/esbuild#578
from esbuild-loader.
Related Issues (20)
- The current version is not supported module federation build production HOT 1
- Doesn't work well with esbuild 0.18.x and inherited `tsconfig.json` and `experimentalDecorators` HOT 5
- esbuild 0.18 HOT 2
- sourceMappingURL getting removed by minifier HOT 1
- Define property causes bundle to minify HOT 7
- enable esbuild-loader with relay plugin HOT 1
- After upgrading from esbuild 3 version to version 4, the following error message occurs when yarn start is executed. HOT 3
- Define property prevents bundle from minifying HOT 1
- ngDevMode is not defined, when building Angular 15.2 or higher HOT 2
- Optional Chaining not working HOT 1
- Module resolution problems HOT 6
- upgrading from v3 to v4 breaks build for TS projects HOT 11
- Only 1 plugin working at a time HOT 2
- Float's optimization HOT 1
- reference errors on build instead of hoisting HOT 1
- "Module not found" error causes esbuild-loader to crash with "Cannot read properties of undefined (reading 'useSourceMap')" HOT 3
- Support for Debugging styled-components with esbuild-loader HOT 1
- Enable "dynamic-import" by default HOT 2
- File '@ljharb/tsconfig' not found. HOT 7
- The automated release is failing 🚨
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esbuild-loader.