Giter VIP home page Giter VIP logo

Comments (4)

privatenumber avatar privatenumber commented on May 13, 2024 4

Re-opening as esbuild v0.11.15 has an option to remove comments.

from esbuild-loader.

privatenumber avatar privatenumber commented on May 13, 2024 1

This is by design on esbuild's end:

And all comments other than license-related comments are stripped out by esbuild anyway.

Can you open an issue here?

I think minification-benchmarks can also benefit from a more nuanced control over removing comments as other minifiers support it.

from esbuild-loader.

privatenumber avatar privatenumber commented on May 13, 2024 1

I would still open a feature request about having granular control over whether license comments should be kept. Some authors might be referencing licenses in a separate file instead of the JS code.

Since esbuild preserves @license comments, you can try removing it to trick esbuild into thinking it's an ordinary comment.

As an example, you can use code-inject-loader to accomplish this:

{
	loader: 'code-inject-loader',
	options: {
		transform: src => src.replace(/@license/, '')
	}
},
{
	loader: 'esbuild-loader',
	...
}

Note that this is risky because it doesn't guarantee that @license is used as a part of a comment.

from esbuild-loader.

josteph avatar josteph commented on May 13, 2024

Thanks for the reference 👍

Edit:
I believe it has been answered here evanw/esbuild#578

from esbuild-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.