Getting a strange dependency error about html-to-docx HOT 6 CLOSED

@homeslicesolutions Yup these all arose from libtidy-updated and that is the menace, I guess best is to remove that altogether and then make this library compatible with browser eventually. Feel free to raise a PR to develop branch.
@amrita-syn Thoughts?

from html-to-docx.

Makes sense. Anyway this repo should expect 'clean' html and user can ensure cleanliness through a method of their choice. We should specify the HTML standard that is required for correct file generation and leave it at that. Examples with and without libtidy can be shown for those who would want to use it.

@privateOmega We will have to modify the way we are using the package to accommodate these changes.

from html-to-docx.

@amrita-syn Exactly my thought too. 👍

from html-to-docx.

@privateOmega , I also noticed that you use xmlbuilder2 which is also a node.js library. When tried to use it in the browser in my React application, I get the following error

Uncaught (in promise) TypeError: Cannot call a class as a function
    at e.exports (classCallCheck.js:3)
    at new r (NodeImpl.ts:93)
    at r.<anonymous> (createSuper.js:14)
    at new r (DocumentImpl.ts:69)
    at Object.t.create_document (CreateAlgorithm.ts:61)
    at new r (WindowImpl.ts:28)
    at Function.value (WindowImpl.ts:41)
    at Object.t.create_window (CreateAlgorithm.ts:47)
    at e.get (DOMImpl.ts:68)
    at new e (DOMImplementationImpl.ts:27)

from html-to-docx.

@homeslicesolutions @amrita-syn I have created a PR which removes libtidy altogether from html-to-docx side, so I guess people who would want to tidy HTML input before it comes into html-to-docx can use their own preferred html cleaner package.

from html-to-docx.

@homeslicesolutions Published new version v1.1.31, which essentially removes libtidy from it, hence wouldn't cause anymore of the weird dependency issues.
Also I had created an issue on XMLBuilder2 repo, but not sure how I would create a test case for it.
Closing the current issue since the issue in scope is resolved.

from html-to-docx.