Giter VIP home page Giter VIP logo

Comments (7)

privateOmega avatar privateOmega commented on July 18, 2024

@RoxnnyABarriosC Please raise a PR with this typescript definition, and also do we need any sort of typescript configuration to make use of this definition?

from html-to-docx.

ndrewtl avatar ndrewtl commented on July 18, 2024

I believe that in order to use typed definitions, you need to open a PR at https://github.com/DefinitelyTyped/DefinitelyTyped. That will allow users to import @types/html-to-docx. These definitions looks alright to me, @privateOmega , are they alright with you? If so, then either @RoxnnyABarriosC or I can open a PR on DefinitelyTyped.

from html-to-docx.

privateOmega avatar privateOmega commented on July 18, 2024

@ndrewtl Not exactly, Definitely typed is a huge mono-repo hosting type definitions for different package and has deployment strategies to deploy the type definitions of each package separately.

I would be very happy to see the entire package migrated to typescript as well, but time is an issue. But if one you could take it up, I could probably assist, else you can raise a PR to this package itself, specifying "types" field in package.json. The benefit of us keeping the ts definition file inside the repo, also helps keeping it in sync in case any apis change as well.

from html-to-docx.

lvndry avatar lvndry commented on July 18, 2024

Any updates on this ?

from html-to-docx.

jafin avatar jafin commented on July 18, 2024

@privateOmega RE: typescript. I've created a branch converted to typescript. It's working locally, if useful I can do up a PR.
https://github.com/jafin/html-to-docx/tree/feat/typescript

from html-to-docx.

whis20 avatar whis20 commented on July 18, 2024

@jafin when will this PR be up ? it looks promising.

from html-to-docx.

artemdumanov avatar artemdumanov commented on July 18, 2024

As a workaround, you can use
// @ts-ignore

from html-to-docx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.