Giter VIP home page Giter VIP logo

Comments (7)

bkeepers avatar bkeepers commented on August 19, 2024 2

Seems like a reasonable feature. The easiest way to implement it would probably be to copy how different settings can be specified for issues and pulls. Maybe there could be a labels top level key, where settings can be specified for each label. Something like:

labels:
  x:
    daysUntilStale: 1
    daysUntilClose: 1
  y:
    daysUntilStale: 14
    daysUntilClose: 3
As an aside, I had thought about some drastic changes to stale configuration at one point that I think would also fit this use case…

The TL;DR, is that it should allow specifying an unlimited number of configurations. It might look something like this:

mark x stale issues:
  if:
    days: 1
    label: x
    is: issue
  then:
    label: stale
    comment: Whatever you want to say when marking the issue

close x stale issues:
  if:
    days: 1
    labels:
    - x
    - stale
    is: issue
  then:
    close: true
    
mark y stale issues:
  if:
    days: 14
    label: y
    is: issue
  then:
    label: stale
    comment: Is this still relevant? If so, please comment with any updates or addition details.

close y stale issues:
  if:
    days: 3
    labels:
    - y
    - stale
    only: issues
  then:
    close: true

So if you wanted different configuration for each label, you'd just use the if…label combination.

This is a drastic change, so I wouldn't wait for it to happen before exploring a solution, but wanted to throw it out there.

from stale.

elliotblackburn avatar elliotblackburn commented on August 19, 2024 1

The logic based configuration looks like a really good idea for future extensibility and could open the doors to a highly custom configuration. One could probably use the logic system to power all existing configurations during it's implementation but as you said that's a very drastic change to the system.

The first proposal also seems like a good and simple approach to take, should be easy to lookup configuration for different issues. I guess a question it prompts though is what happens it two labels cause a rule conflict? I'm assuming it would be sensible to take the longest (thus most lenient) rule and apply it.

from stale.

stale avatar stale commented on August 19, 2024

Is this still relevant? If so, please comment with any updates or addition details.

from stale.

elliotblackburn avatar elliotblackburn commented on August 19, 2024

I believe this is still relevant to the probot stale project, at least no discussion has taken place to indicate otherwise 😄

from stale.

stale avatar stale commented on August 19, 2024

Is this still relevant? If so, please comment with any updates or addition details.

from stale.

elliotblackburn avatar elliotblackburn commented on August 19, 2024

Yes this is still relevant and has been referenced in other issues

from stale.

stale avatar stale commented on August 19, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

from stale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.