Implement curves about p5.js HOT 16 CLOSED

jumping on this.

from p5.js.

bezier and curves done, vertexes next.

from p5.js.

Aight, time to finish this bidness up. cracks knuckles

from p5.js.

Good luck! Also, you might need to rebase soon. I will let you know on this comment thread.

from p5.js.

@thethp Hi! Thank you so much for all the great work so far!

I wanted to let you know that we just pushed a pretty big re-org to src/core.js. So, you might need to rebase since you added a few curve variables in there. We ask that you put underscores under private vars on p5 (as you already have) and then put all those private vars down in the 'Private p5 Properties' section of the code. Let me know if you have issues!

from p5.js.

@evhan55 thanks! Much obliged, I'll do a rebase right now! :squirrel:

from p5.js.

hey @thethp what's left to do on this?
it looks like we're just missing:

• curveTightness()
• curveVertex()

is this correct? are you interested in finishing this up or do you want me to take a look?
asking because we're aiming for a more public release early next month and would love to nail down the curves/vertex stuff by then :)

from p5.js.

Sorry guys! I got distracted! I'm getting back on this today.

from p5.js.

awesome! we've been making moves on this library... make sure you pull the newest. let me know if anything has stopped building or you have any questions, happy to help!

from p5.js.

merging upstream into my branch now :D Thanks!

from p5.js.

I've just added all the examples to Vertex.js and have added comments to the ones that aren't behaving as expected (mostly the beginShape examples). All the examples run fine for Curves except curveTightness as it's not implemented.

I think they're not working properly because of the order in which JS is trying to do the drawing. I commented on this for endContour(). On the processing.org refs the Exterior shape is drawn right after beginShape(), it's not visible unless it's drawn after endContour().

Can be seen here: https://github.com/derekkinsman/p5.js/blob/derek/src/shape/vertex.js

from p5.js.

hmm yes, I guess this is the same problem I was seeing here:
https://github.com/lmccart/p5.js/issues/239

so it's not just triangle_strip I guess but something with the way curves is working

from p5.js.

one example of above difference here:
http://processing.org/examples/trianglestrip.html
vs
http://p5js.org/site/learning/examples/Triangle_Strip.php

from p5.js.

It might have something to do with the < canvas > fill property.

http://www.w3.org/TR/2011/REC-SVG11-20110816/painting.html#FillProperties

from p5.js.

ok looked into it a bit more. I think the arguments for beginShape() are just not being accounted for (QUADS, TRIANGLE_STRIP, etc). Right now they are saved but not used anywhere that I can tell.

from p5.js.

@thethp any thoughts on this? looks like right now the verts are being drawn as they're called, but I think the thing to do is to save them all in an array and draw them at the end taking into account the shape mode. I'm happy to take a pass at this but I don't want to mess with the work you've done if you would rather finish this off using the system you've set up. let me know!

from p5.js.