Giter VIP home page Giter VIP logo

Comments (4)

gabriel-farache avatar gabriel-farache commented on July 2, 2024

We have to update to Go 1.17 or greater before doing this.
Newer version of the go-client are pulling dependencies that cause errors when building:

 sigs.k8s.io/controller-runtime/pkg/log
vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:163:2: cannot use res (type *DelegatingLogger) as type logr.Logger in return argument
vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:179:2: cannot use res (type *DelegatingLogger) as type logr.Logger in return argument
vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:195:2: cannot use res (type *DelegatingLogger) as type logr.Logger in return argument
vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:67:26: cannot use NullLogger{} (type NullLogger) as type logr.Logger in argument to Log.Fulfill
vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:82:41: cannot use NullLogger{} (type NullLogger) as type logr.Logger in argument to NewDelegatingLogger
vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:86:6: cannot use Log (type *DelegatingLogger) as type logr.Logger in assignment
vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:88:13: assignment mismatch: 1 variable but logr.FromContext returns 2 values
vendor/sigs.k8s.io/controller-runtime/pkg/log/null.go:30:5: cannot use NullLogger{} (type NullLogger) as type logr.Logger in assignment
vendor/sigs.k8s.io/controller-runtime/pkg/log/null.go:48:32: undefined: logr.InfoLogger
vendor/sigs.k8s.io/controller-runtime/pkg/log/null.go:54:2: cannot use log (type NullLogger) as type logr.Logger in return argument
vendor/sigs.k8s.io/controller-runtime/pkg/log/null.go:54:2: too many errors
# sigs.k8s.io/json/internal/golang/encoding/json
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
# github.com/go-logr/zapr
vendor/github.com/go-logr/zapr/zapr.go:138:9: cannot use &zapLogger{...} (type *zapLogger) as type logr.Logger in return argument
vendor/github.com/go-logr/zapr/zapr.go:157:9: cannot use &zapLogger{...} (type *zapLogger) as type logr.Logger in return argument

Only option is to update the go version.
I'll take over issue #153 based on PR #172

from flotta-operator.

masayag avatar masayag commented on July 2, 2024

Seems that with recent upgrade to go 1.17, controller-runtime and client-go were upgraded as well.

from flotta-operator.

gabriel-farache avatar gabriel-farache commented on July 2, 2024

Yep, @arielireni updated dependencies when upgrading to go 1.17 with PR #163 and @tupyy has submitted PAR #186 to use retry watcher

from flotta-operator.

tupyy avatar tupyy commented on July 2, 2024

PR #186 merged. I'm closing this issue

from flotta-operator.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.