Comments (10)
Yes, makes sense.
from node-osrm.
I'll expose a parameter to the library constructor that allows you to mute the logging. Does that make sense to what you have in mind?
from node-osrm.
Yes. Was thinking silent by default and then verbose mode can be turned on. Plan to model this in node-osrm around how node-sqlite3 works.
from node-osrm.
k, cool. Will dig a bit into node-sqlite3 to get a better impression.
from node-osrm.
node-sqlite
has db.on('trace'..
and db.on('profile'..
events you can hook into:
- https://github.com/developmentseed/node-sqlite3/blob/master/test/profile.test.js
- https://github.com/developmentseed/node-sqlite3/blob/master/test/trace.test.js
And node-blend
has a third arg that is passed to callbacks (which were run in the thread pool) that provides an array of warnings:
These are candidates for how to design ways to get more debugging info. But, on further thought I think this is overkill for now in terms of node-osrm. Just being able to mute things sounds just fine for now!
from node-osrm.
the current plan is to have a policy singleton that describes if logging is muted or not. And then a simple object that overrides std::ostringstreamoperator<< and which collects output. On destruction, it writes stuff to console. Usage will then be similar to Log().Get(logWarning) << "important message";
from node-osrm.
okay, sounds good. And familiar to the new boost log and the mapnik debug framework
from node-osrm.
Right, unfortunately the boost log library is not yet old enough to have trickled down into current linux distros.
from node-osrm.
This is now implement in Project-OSRM/osrm-backend@44eed92. The default is that logging is disabled. To enable, toggle the that of the LogPolicy
singleton class:
LogPolicy::GetInstance().Unmute();
Likewise .Mute()
silences any output. Logging messages is as easy as
SimpleLogger().Write() << "super informative message goes here";
whereas .Write()
takes a parameter to indicate logging level:
- logINFO (default)
- logWARNING
- logDEBUG
from node-osrm.
fantastic, tests for node-osrm now run cleanly and without noise :)
The blue ones are pending, see #8 for details.
from node-osrm.
Related Issues (20)
- Odd failure on linux with coverage build HOT 1
- Architecture optimized binaries HOT 1
- Un-mute logging in debug mode HOT 1
- osrm-extract error - attempt to call global 'canonicalizeStringList' (a nil value) HOT 4
- Installing via npm fails to build from source HOT 16
- Bundle osrm-components with node-osrm HOT 5
- Bundle osrm-unlock-all and other tools HOT 4
- Add support for geometries parameter polyline6
- macOS compilation issue with current osrm-backend master HOT 3
- cannot build never than v5.3.3 node-osrm from source HOT 11
- Wrap: Trip with Fixed Start and End points (TFSE) HOT 1
- Can't install node-osrm after install osrm-backend HOT 5
- Failing `annotations` tests HOT 1
- Wrap: Allow annotations parameter to accept specific fields HOT 7
- Expose `generate_hints` Parameter
- Installation issues with node v4.2.6, npm v3.5.2 HOT 2
- Precompiled binaries fail on alpine linux HOT 3
- Deprecate repository HOT 1
- How to use it or run it HOT 2
- dlopen failed: "/node_modules/osrm/lib/binding/node_osrm.node" has bad ELF magic HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-osrm.