Drop static linking? about node-osrm HOT 9 CLOSED

Yes, I think this is what we'll need to do. It will make offering portable node-osrm binaries slightly more complicated but should be doable. What I see happening is:

• libtbb and libOSRM become built as shared libraries (dylib/so).
• They are still linked to static libraries for all dependencies (liblua, libboost, etc)
• After node-osrm binaries are built libtbb and libOSRM will be copied into the lib/binding directory beside osrm.node
• On OSX we can use @loader_path to ensure relative loading works
• On Linux we can link osrm.node with -Wl,$ORIGIN to ensure relative loading works
• If the user has set LD_LIBRARY_PATH to a directory that includes an externally built libtbb or libOSRM and it is binary incompatible then osrm.node will be broken. So, to ensure this never happens we could optionally rename the libraries to something unique before bundling.

from node-osrm.

@springmeyer lets do voice on this tomorrow or early next week. We should go for the low maintainance solution.

from node-osrm.

Summary of chat with @DennisOSRM

tl;dr: - I'm going to get travis builds working with shared TBB - shooting to have this working by early next week.

Overall notes:

• The approach of travis + mapnik-packaging + node-pre-gyp + static libraries makes it easy to install node-osrm for non developers but can make it more painful to get releases out.
• The introduction of the need for TBB being a shared lib is blocking things
• Luckily @springmeyer recently made a concession and started packaging libgdal as a shared lib, so along the way figured out how to get this working within node-pre-gyp binaries.
• We should consider using debian packaging for OSRM/node-osrm in the future if node-pre-gyp approach introduces more pain points
• But for now, just packaging TBB as a shared lib should get things unblocked and working well again

from node-osrm.

First build up with TBB shared, and travis is passing again: https://travis-ci.org/DennisOSRM/node-osrm/builds/28076849. I'm building TBB from source like so: https://github.com/mapnik/mapnik-packaging/blob/master/osx/scripts/build_tbb.sh. Their Makefiles are totally unconventional so it took some time to figure out how to work with them.

Next actions:

• test binaries on linux
• get an alpha package out with shared tbb to make sure it can be installed on 14.04 without trouble
• test whether having an externally apt-get installed TBB breaks then node packaged version

from node-osrm.

All done here - workflow is now using shared tbb and packaged binaries work. Next action would be to make an official tag against an updated HASH of OSRM.

from node-osrm.

👍

from node-osrm.

@springmeyer where does it drop the shared object and the header files? It's not yet picked up:

ERROR: Intel TBB NOT found!
-- Looked for Threading Building Blocks in /tmp/gjs4FeTgSZM/mapnik-packaging/osx/out/build-cpp11-libstdcpp-gcc-x86_64-linux
CMake Error at cmake/FindTBB.cmake:272 (message):
  Could NOT find TBB library.
Call Stack (most recent call first):
  CMakeLists.txt:168 (find_package)

from node-osrm.

re-opened will investigate.

from node-osrm.

Closing again. Now working over at #58 #59

from node-osrm.