Comments (1)
This fix only solved part of the problem and wasn't the actual root problem where the bug is.
The problem is not when it's serialized. The problem is it had an incorrect route to begin with due to string manipulation in the graph. This happened when we added nested routes. We now have to revert this fix and update graph.js:
// get remaining string after user's pages directory
let subDir = filePath.substring(pagesDir.length - 1, filePath.length);
By adding the -1 we're including the /
in our routes. When the route is serialized, it does not add a duplicate index folder. The previous fix only solved one part of the issue. The reason it passed unit tests is because even when we're testing the index file, the elements all rendered but they were not within the correct route. Had we tested via puppeteer however, this wouldn't have passed.
Also app-template has a default route at /
with a component of eve-index
this is no longer required to be added by default within the template. scaffold.js can already take care of it. Re-opening and refixing.
from greenwood.
Related Issues (20)
- plugin-graphql importing apollo/client file that no longer exists in recent releases
- deprecate import maps shim for development
- add support for configuring a base path
- single file bundles (SFBs) for SSR page and API routes HOT 1
- markdown rendering not correctly processing the text `$1`
- minimal `Response` throws errors in development and production lifecycles
- implement a more idiomatic (HTML) templating solution
- upgrade plugin-typescript to TypeScript `5.x`
- adapter SSR pages are rendering with incorrect content type header
- Edge Runtime support for Adapter plugins HOT 1
- AWS Adapter plugin HOT 1
- Cloudflare Adapter plugin
- support additional `Request.body` formats
- custom imports bundling breaks when used in API routes and SSR pages
- templates with (inline) template strings breaks bundling of SSR pages
- devServer proxy not returning content (when proxied response includes a `content-encoding` header)
- custom loader hook not handling bare specifiers when resolve URLs (`invalid URL`)
- Isomorphic Asset Bundling
- Content as Data (Content Graph)
- Support "active links" in terminal output for server URLs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from greenwood.