Fails to find GLuint about projectm HOT 17 CLOSED

Odd, it's building for me on OSX and linux ok: https://travis-ci.org/projectM-visualizer/projectm/builds/350333601

Down below it should include:

#ifdef __linux__
#ifdef USE_GLES1
#include <GLES/gl.h>
#else
#include <GL/gl.h>
#include <GL/glx.h>
#endif
#endif

May I ask what system this is?

from projectm.

May I ask what system this is?

FreeBSD. I am trying to update the port.

from projectm.

Okay, I'm assuming #ifdef __linux__ isn't the best check for FreeBSD. What would be a better define to check? Does it need to be changed everywhere?
Also, do you know if Travis supports FreeBSD? Would be good to have CI for it.

from projectm.

Also may need to add a BSD check in configure.ac under "Freedom":
https://github.com/projectM-visualizer/projectm/blob/master/configure.ac#L66

from projectm.

Please let me know how I can assist!

from projectm.

@yurivict peep #37
Builds for me ok

from projectm.

@revmischa The problem is gone with this patch.

One thing though is that I personally would've used:

#if defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) || defined(__DragonFly__)

This catches all linuxes and all BSDs.

__unix__ might catch some systems like MacOS or CygWin where we don't know if this should be changed.

from projectm.

Or maybe GL/gl.h should be included unconditionally, because the use is unconditional?

from projectm.

It appears to build on OSX: https://travis-ci.org/projectM-visualizer/projectm/builds/351963692

They all have:

#ifdef __APPLE__
#include <OpenGL/gl.h>
#endif

However. Maybe it should be:
#elseif __unix__ ...?

from projectm.

I would do:

#ifdef __APPLE__
#include <OpenGL/gl.h>
#endif

#if defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) || defined(__DragonFly__)
#include <GL/gl.h>
#endif

It is easier to read (no elseifs), and doesn't make assumptions about systems we aren't sure about.

from projectm.

This could probably be cleaner, give me a minute to examine.

from projectm.

is defined() a preprocessor keyword or something? i've never come across it before

from projectm.

yes it is, about to upload a patch with that as an example, but I can't build this today so maybe it can be improved upon.

from projectm.

thanks! if one of you wants to open a new PR feel free.

from projectm.

also see the configure.ac link i added earlier.. are there any flags needed for linking on freebsd? apple needs -framework CoreFoundation and limux needs -ldl. idk what bsd needs.

from projectm.

There is no -ldl on BSDs.

from projectm.

Closing in favour of #41

from projectm.