Question on editing properties of Node/ Port Models about react-diagrams HOT 8 CLOSED

lastly, theres another cool guy thats using this project and is doing something similar, but he added text fields to the nodes themselves, for an example on how he is doing it you might find this interesting:

https://github.com/mwozniczak/adventure-weave/blob/master/src/widgets/SceneNodeWidget.tsx#L51

from react-diagrams.

Hey, thanks for reaching out! mind jumping onto Gitter quickly?

from react-diagrams.

its really strange that the links are getting deleted. The only time the system will delete the links, is if the ports happen to change, and so the links can no longer be connected. So I'm concerned that the model you are mutating is not the same model that the diagram engine is using. You should DEFINITELY be able to mutate the model and then repaint. You can also control what gets repainted down the whole tree by calling:

//first call this and pass in an array of models that you want to change
diagramEngine.enableRepaintEntities(entities: BaseModel<BaseModelListener>[]);

//then
diagramEngine.repaintCanvas() or forceUpdate() in your wrapper component

//and then finally
diagramEngine.clearRepaintEntities();

from react-diagrams.

to find out why the links are being deleted, take a look at this line:

https://github.com/projectstorm/react-diagrams/blob/master/src/widgets/LinkLayerWidget.ts#L49

as well as

https://github.com/projectstorm/react-diagrams/blob/master/src/widgets/LinkLayerWidget.ts#L60

from react-diagrams.

Yeah, I was just about gonna jump in here and toot my own horn for a minute there*, you beat me to it :D

@kriskrss you might wanna look at what @dylanvorster linked to, in particular what I'm doing with the composites.

Anyway, a potential workaround if the above doesn't work for you, might be have the title a new property of your NodeModel, and just render that in the widget.

*jeez i hope this is the right expression

from react-diagrams.

Thanks for the quick response!, I am building a redux app around this. So trying to make sure the model transitions also go through the redux dispatcher-reducer framework.

I was storing the model in my state and re-drawing on a new engine every time.

From what you guys mentioned, may be its better to just store the engine instead.

Will let you know how it goes.

Thanks guys!

from react-diagrams.

Can I close this issue?

from react-diagrams.

Sure, I can create another one if I find that this is a bug :)

from react-diagrams.