Giter VIP home page Giter VIP logo

Comments (8)

zwopir avatar zwopir commented on June 12, 2024 1

Yes, looks reasonable. If all supported ES versions expose the metrics, it's just a matter of adding a few struct fields - no fancy logic involved. I'll check it asap. If not we need to find a solution how to handle different json input from the stats endpoint.

from elasticsearch_exporter.

gehel avatar gehel commented on June 12, 2024 1

Thanks! I'll test this as soon as I find some time...

from elasticsearch_exporter.

gehel avatar gehel commented on June 12, 2024 1

After far too long, I finally deployed that new version. All looks good! Thanks for the help!

from elasticsearch_exporter.

gehel avatar gehel commented on June 12, 2024

For reference, this is tracked on our side at https://phabricator.wikimedia.org/T181627

from elasticsearch_exporter.

dominikschulz avatar dominikschulz commented on June 12, 2024

At first sight it looks reasonable to add those metrics but I want to check back with @zwopir

from elasticsearch_exporter.

gehel avatar gehel commented on June 12, 2024

Looking at the history of our diamond collector, we changed almost nothing since 2 years ago. I would need to check what version of elasticsearch we were running at that time, but it should be compatible back to at least 2.x, possibly 1.8. We are running this collector on 5.5 at the moment. I have not checked compatibility with ES 6.x yet.

Thanks for looking into this!

from elasticsearch_exporter.

dominikschulz avatar dominikschulz commented on June 12, 2024

@gehel Thanks! I know that problem wrt. time ;) I'm sorry this took so long, somehow my PR got lost over Christmas.

from elasticsearch_exporter.

dominikschulz avatar dominikschulz commented on June 12, 2024

@gehel Amazing. Thanks for reporting back!

from elasticsearch_exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.