Comments (10)
Thanks! This seems related to #17 also reported this morning.
from js-xlsx.
Referred to main branch SheetJS#339
from js-xlsx.
@araymer Might you have a test case I can use to verify? Even a snippet is helpful, need not be a complete mocha test.
Any suggestion why strings were broken, e.g. './js'+'zip'
vs simply jszip
? It looks like it was added to /bits/21_ziputils.js
on 7/28/14 with this commit message.
version bump 0.7.8: docs, defaults, details
- browser shim updated (h/t @wintersm for discovering this)
- smart tag ignores (h/t @lostinplace)
- sheet_to_row_object_array bugfix (fixes #80, h/t @ChrisBurkeBSD)
- README improved
- baltic and vietnamese codepages: updated codepage to 1.3.4
- iOS Numbers can handle inline strings -> disabling SST by default
- avoid Buffer accessors (see nodejs/node-v0.x-archive#7809)
- caching certain hot regexes
from js-xlsx.
Honestly, I have no idea why the strings weren't written contiguously for the require methods. I kept it as such out of caution. In my mind, it seems like it shouldn't make a difference.
As for a test case: I don't, sorry. I made the change on the project I was working on and just kinda went with it because it seemed to work fine (we were using bower, requireJS and angularJS with a .net backend. So, no node support beyond the build, but still needed modularity.)
from js-xlsx.
I guess that this was an optimization to avoid loading of jszip if it is included into document already. The problem is that module loaders like System.js parses such files statically to find dependencies but they don't do event primitive code evaluation inside require
statements.
Fixing this would be very helpful.
from js-xlsx.
I'd be happy to make a pull request that concatenates these strings, if it would be accepted.
from js-xlsx.
Are you able to run the test suite?
from js-xlsx.
@pietersv Yes, this is the final output when I run make test
:
This is for a clean clone of the repo.
from js-xlsx.
@mattbasta That's awesome. May I ask how you were able to run these, what Node version? On a clean clone of the root project on Node 4.1.1 I get 937 failed tests.
from js-xlsx.
We are using 0.10. I used the instructions in the readme.
from js-xlsx.
Related Issues (20)
- Add comments/note can not export or export very slow, without comments, it will export very quick
- vite上怎么配置config.externals({ "./cptable": "var cptable" }); HOT 8
- add some comment XLSX.write page unresponsive
- Why I installed js-xlsx, there is no json_to_sheet method after import
- Not able to at add comments to the cell while writing it through xlsx-style.
- Depends on vulnerable versions of jszip
- cptable is not defined
- Need to remove unprotected cells containing formula warning icon in excel sheet
- How to set cell wrapping?
- How to parse ‘excel formula' using node js to get the actual value from the excel sheet.
- How use typescript in this project?
- Please lock the commander version, otherwise it cannot support Node v12
- Read styles for HTML table cell
- jszip is not a constructor
- How to set different text styles in cells with xlsx-style , example: C3:{ t : "s" v : "<p>Update Wifi long-term supply <span style=\"text-decoration: underline;\">plan</span> and impact to <strong>production</strong> }
- js.forEach is not a function HOT 1
- RollupError: Could not resolve "../xlsx" from "../xlsx?commonjs-external" HOT 1
- Denial of Service (DoS) affecting package jszip.
- Excel to PDF Page size and scaling issue
- what is this issue i am not able to understand and resolve
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js-xlsx.