"no-empty-blocks": ["error", { "ignoreConstructors": true }] not working about solhint HOT 6 CLOSED

@CJ42
sorry but there is no such configuration for that rule

see https://github.com/protofire/solhint/blob/master/docs/rules/best-practises/no-empty-blocks.md

you can open an issue to suggest adding that... we can address it for forthcoming versions

from solhint.

This release suggests that this option exist

https://github.com/protofire/solhint/releases/tag/3.5.1

from solhint.

omg!
That is weird
I'll check that asap
@CJ42 sorry for the bad response

from solhint.

ok... I checked
See this thread for more info:
#418

The changelog is missleading there is no such option... you can check the code. There is no configuration option for that rule as stated in the rule help readme
https://github.com/protofire/solhint/blob/develop/lib/rules/best-practises/no-empty-blocks.js

The rule just ignores an empty constructor as long as a base contract is being inherited
It will ignore this empty constructor because it is used to initialize the token contract:

// SPDX-License-Identifier: Apache-2.0
pragma solidity ^0.8.4;

import { ERC20Burnable} from "@openzeppelin/contracts/token/ERC20/extensions/ERC20Burnable.sol";

contract PayableContract is ERC20Burnable{
    constructor() ERC20("MyToken", "MTK") {}

    // solhint-disable no-empty-blocks
    function payableTrue() public payable {}

    // solhint-disable no-empty-blocks
    function payableFalse() public {}
}

But it will be a warning to this:

// SPDX-License-Identifier: Apache-2.0
pragma solidity ^0.8.4;

contract PayableContract {
    constructor() {}

    // solhint-disable no-empty-blocks
    function payableTrue() public payable {}

    // solhint-disable no-empty-blocks
    function payableFalse() public {}
}

Because there is no need to define an empty constructor...

from solhint.

@dbale-altoros Ok that makes sense, thank you for the clarification!
It would be good to document this imo (either in the Release detail or somewhere else), as it is not immediately clear when reading the CHANGELOG.

from solhint.

yes will do

from solhint.