Comments (5)
Niko Wolf
January 22nd, 2014 @ 04:07 PM
Here's my quick fix (goal was to avoid changing the original prototype.js).
Include the following after prototype has loaded:
Prototype.Browser = (function(res) {
var ua = navigator.userAgent;
if(ua.include('Trident')){
res.Gecko = false;
res.IE = true;
}
return res;
})(Prototype.Browser);
from prototype.
Completely on the fence as to whether I should even bother to fix this. All the tests pass in IE 11, so the fact that we might think it's Firefox certainly isn't hurting us at all.
from prototype.
I think the importance of this issue depends on whether this flag is meant to be internal to PrototypeJS, or public for PrototypeJS-using applications to use. I just tried to use this flag in my application, and had to add in jwestbrook's additional test for IE 11. The documentation at http://api.prototypejs.org/Prototype/Browser/ makes it look like the IE flag is meant to be public.
from prototype.
Yeah, I wanted this to let me detect IE but it didn't, reliably. I got Gecko on IE12/Win10.
There's also Edge to consider, which is detected as WebKit.
from prototype.
These flags are used internally to replace normal code with work-arounds, so you don't try to do something on Firefox that you need to do on IE 9, since that might cause Firefox to stop working. If IE 11 passes all the tests, then the only reason to test for IE is if you want to know for some reason, not because ordinary Prototype standard code won't work in that browser, and something needs to be worked around.
Walter
On Nov 10, 2015, at 7:46 AM, GreenReaper [email protected] wrote:
Yeah, I wanted this to let me detect IE but it didn't, reliably. I got Gecko on IE12/Win10.
There's also Edge to consider, which is detected as WebKit.
�
Reply to this email directly or view it on GitHub.
from prototype.
Related Issues (20)
- Native Array.prototype.filter is overwritten by prototype HOT 1
- Native Array.from is overwritten by $A which is not able to handle all cases used by the native function HOT 5
- Unable to build on Windows (no tar command) HOT 5
- Uncaught TypeError: $(...).getValue is not a function HOT 5
- Global.Node has the potential of being overwritten.
- Array.prototype.toJSON requires double parsing after stringify HOT 1
- Compatibility with RetroZilla HOT 6
- Security Issue: Request for contact HOT 4
- Uncaught SyntaxError: unexpected token: ':' HOT 2
- https://api.prototypejs.org/ seems to be down. HOT 3
- Warning: Potential Security Risk Ahead https://api.prototypejs.org/ HOT 1
- Fixing JS injection HOT 2
- Typescript declarations?
- CVE-2020-27511 HOT 5
- Element.replace() swaps element and textNode if used inside a table
- prototype.js is causing chart.js to not work HOT 2
- Array.from doesn't work with some iterables HOT 1
- $F throws an error when missing element
- Prototype is no longer compatible with Vue.js HOT 2
- Future and present of Prototype.js HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prototype.