Giter VIP home page Giter VIP logo

Comments (5)

jwestbrook avatar jwestbrook commented on August 17, 2024

Niko Wolf
January 22nd, 2014 @ 04:07 PM

Here's my quick fix (goal was to avoid changing the original prototype.js).
Include the following after prototype has loaded:

Prototype.Browser = (function(res) {
    var ua = navigator.userAgent;

    if(ua.include('Trident')){
        res.Gecko = false;
        res.IE = true;
    }
    return res;
})(Prototype.Browser);

from prototype.

savetheclocktower avatar savetheclocktower commented on August 17, 2024

Completely on the fence as to whether I should even bother to fix this. All the tests pass in IE 11, so the fact that we might think it's Firefox certainly isn't hurting us at all.

from prototype.

plynchnlm avatar plynchnlm commented on August 17, 2024

I think the importance of this issue depends on whether this flag is meant to be internal to PrototypeJS, or public for PrototypeJS-using applications to use. I just tried to use this flag in my application, and had to add in jwestbrook's additional test for IE 11. The documentation at http://api.prototypejs.org/Prototype/Browser/ makes it look like the IE flag is meant to be public.

from prototype.

GreenReaper avatar GreenReaper commented on August 17, 2024

Yeah, I wanted this to let me detect IE but it didn't, reliably. I got Gecko on IE12/Win10.

There's also Edge to consider, which is detected as WebKit.

from prototype.

walterdavis avatar walterdavis commented on August 17, 2024

These flags are used internally to replace normal code with work-arounds, so you don't try to do something on Firefox that you need to do on IE 9, since that might cause Firefox to stop working. If IE 11 passes all the tests, then the only reason to test for IE is if you want to know for some reason, not because ordinary Prototype standard code won't work in that browser, and something needs to be worked around.

Walter

On Nov 10, 2015, at 7:46 AM, GreenReaper [email protected] wrote:

Yeah, I wanted this to let me detect IE but it didn't, reliably. I got Gecko on IE12/Win10.

There's also Edge to consider, which is detected as WebKit.


Reply to this email directly or view it on GitHub.

from prototype.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.