Comments (3)
Hi @Fennerr, we've talked internally about this possibility:
- The
detect-secrets
library has not the ability to show the detected secrets in plaintext. We could extract it from the source code using the line reported by the library. - We think is not a good practice to output the detected secret in the Prowler output.
- We think is enough to have the secret type and the line number for the auditor because you can pass that information to the code owner to fix the issue in a secret manner.
What do you think?
from prowler.
@jfagoagas that makes sense. I did notice that detect-secrets
didnt actually store the the secret as plaintext, and thought about extracting it from the temp file it flagged on. But it could make the output very messy, especially if there are very long lines (such as a block of high entropy base64 encoded data).
What about having an option to store the lambda function's code in a detect-secrets-output
folder within the output
folder?
The last account I was looking at, the check flagged for ~180 lambda functions. It takes a while cross-referencing prowler to the lambda in the account (and switching regions), and since the code was already downloaded when prowler ran, it would be nice to have an option to preserve the code.
This would be an opt in option.
It could also be part of how secrets scanning is handled in general in the future (with a multiprocessing pool for secrets detection checks - as these checks are often CPU intensive and don't benefit from multithreading pools)
from prowler.
@Fennerr I'm not sure about saving code locally even with an option. I'm still don't get the benefits of having the source code just if it contains some plaintext secrets, but for sure you find value in that so we can discuss about it.
from prowler.
Related Issues (20)
- [Bug]: efs_not_publicly_accessible does not consider recommended AWS condition. HOT 3
- [Bug]: Encoding issue with Dashboard on Prowler 4.1.0 - Aces High HOT 6
- Look for externally shared DynamoDB Tables HOT 1
- Add support for AWS Lightsail resource HOT 1
- [Bug]: Unable to access the prowler dashboard from aws ec2 instance which has public IP HOT 4
- [Bug]: csv output is empty (only column names) HOT 4
- Add configuration for secret related checks HOT 6
- CIS 2.1.0 output has missing checks [Bug]: HOT 4
- [Bug]: empty json-ocsf output in 4.1.0 HOT 7
- [Bug]: efs_not_publicly_accessible check based on misunderstanding? HOT 5
- [Bug]: V4 sends muted fails to Security Hub HOT 2
- Support for custom metadata fields HOT 2
- [Bug]: Security group name missing from new json-oscf format HOT 5
- [Bug]: Separate Checks for Expired and Near-Expiration ACM Certificates HOT 13
- Add Service Account impersonation in GCP as a new authentication method
- [Bug]: Kubernetes RBAC errors HOT 10
- Bring back HTML reports HOT 1
- Getting FileNotFoundError while trying to set up prowler for aws HOT 13
- Getting Error when using prowler dashboard command - UnicodeDecodeError 'utf-8' codec can't decode byte 0x92 in position 5171 HOT 22
- [Bug]: Unix timestamp not working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prowler.