Comments (6)
Orion.*
->OrionApi.*
Orion.Entities.<name>
->OrionApi.Entities.<name>s
Orion.Events.<name>
->OrionApi.Events.<name>s
EDIT: where <name>
!= World
from orion-core.
I think renaming the Orion
namespace to something like OrionApi
is fitting and acceptable.
What about prefixing the entity names? Something like OrionItem
, OrionNpc
, etc. That way we have differentiation in the code as from the Terraria entities. (As well as name differentiation).
We can probably then leave the namespaces the same.
from orion-core.
I do like prefixing the entity names, but you would still have a conflict with the namespace and the Terraria entity. Since the concrete types are going into TShock, we would name them TshockItem
, TshockNpc
, etc.
Also, something to note is that our type names conflicting with Terraria names shouldn't make too much of a difference in our name decisions, since our goal is to eventually have consumers not need to reference anything in the Terraria namespace.
from orion-core.
Prefixing them with TShock
(or Tshock
, whatever) is good. I would agree with pluralizing the namespaces.
Note: Ignore accidental comment+close
from orion-core.
If there are no objections to the namespace renaming, then I will do this tonight.
from orion-core.
Please detail the exact changes you'll make, for the sake of having it on record+everyone being on the same page.
from orion-core.
Related Issues (20)
- What blocks TShock 5? HOT 6
- Prepare a presentation on Orion API HOT 1
- AAA: Users and Accounts HOT 1
- Orion Framework: Internal Message Queue HOT 10
- Patch CVE-2018-1000210.
- Discussion: Current State of Orion HOT 10
- Discussion: How to handle events HOT 2
- Orion v1.4 Development Progress
- Orion v1.4 "Meta" Progress
- Terraria Projectiles HOT 1
- Terraria Tiles HOT 1
- Automated Documentation HOT 1
- Terraria World HOT 1
- Terraria Tile Entities
- Terraria Packet Definitions
- Improve event infrastructure HOT 1
- Scheduling
- Separate out implementations into launcher HOT 4
- Introduce Liquid structure.
- Interview partners for research about communication in GitHub projects wanted HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orion-core.