Rename packet 82 about tsapi HOT 13 OPEN

Any updates?

from tsapi.

Don't know what a better name is than "LoadNetModule" and "NetModule" isn't a verb either.

from tsapi.

Perhaps ReadNetModule? It just triggers a NetModule to be loaded from the stream.

from tsapi.

ExecuteNetModule?

from tsapi.

Perhaps ReadNetModule? It just triggers a NetModule to be loaded from the stream.

If that's the case, is LoadNetModule not accurate?

from tsapi.

Our PacketTypes.cs naming contains a mix of Verb ActualPacketName and plain ActualPacketName
(e.g., Create CombatText, Complete AnglerQuest, etc.)
I don't really see any renaming that provides extra clarity (from the suggestions provided thus far)

from tsapi.

I'm not entirely sure about renaming it either. I don't believe anything we change it to will actually provide extra clarity as to what the packet does. Since the packet and the logic behind it is quite complex there isn't really anything we can call it that makes it obvious and intuitive.

from tsapi.

I don't know what the packet does.

from tsapi.

& I've heard 10 different explanations for what it does.

from tsapi.

Marking as stalled. This is still a bad packet that does multiple things with no common base

from tsapi.

I suppose NetModule is terraria's next-gen network protocol, but they ended up with just two packets then back to the old one. I'd suggest to call it NetModule because it's different from others.

from tsapi.

This packet defines even more modules as of 1.4

from tsapi.

from tsapi.