Giter VIP home page Giter VIP logo

Comments (14)

wgknowles avatar wgknowles commented on August 22, 2024 1

Broken link checker works a treat!

Sample extract of output:

blc http://localhost:3000/ -roe
Getting links from: http://localhost:3000/docs/how-prysm-works/bls-cryptography
├─BROKEN─ http://localhost:3000/docs/glossaries/terminology.md#proof-of-stake-pos (HTTP_404)
├─BROKEN─ http://localhost:3000/docs/glossaries/terminology.md#validator (HTTP_404)
├─BROKEN─ http://localhost:3000/docs/glossaries/terminology.md#proof-of-stake-pos (HTTP_404)
├─BROKEN─ http://localhost:3000/docs/glossaries/terminology.md#validator (HTTP_404)
Finished! 77 links found. 73 excluded. 4 broken.
Finished! 3774 links found. 3719 excluded. 4 broken.```

from documentation.

har00ga avatar har00ga commented on August 22, 2024

Docusaurus' already print out a list of unresolved links on static build

from documentation.

prestonvanloon avatar prestonvanloon commented on August 22, 2024

Can we add this to our CI pipeline?

Let me know it works and I can add something to fail PRs if they break links

from documentation.

har00ga avatar har00ga commented on August 22, 2024

Reopening as we've experienced issues with docusaurus link debugging feature

from documentation.

prestonvanloon avatar prestonvanloon commented on August 22, 2024

How does the link debugging work? Can we add it to CI pipeline?

from documentation.

prestonvanloon avatar prestonvanloon commented on August 22, 2024

Ping @har00ga

from documentation.

prestonvanloon avatar prestonvanloon commented on August 22, 2024

Another broken link: #94

from documentation.

har00ga avatar har00ga commented on August 22, 2024

Oh sorry, didnt see this notification. From what I gather it's something that can be run on a live site or hard coded into the docs themselves to have the checks performed, not sure which is ultimately simpler but if I had to guess, the live scan. It can likely be run against the live server and links can be checked before every revision push

from documentation.

prestonvanloon avatar prestonvanloon commented on August 22, 2024

Relevant issue: facebook/docusaurus#1111

The idea would be that we run this check on a new PR and fail that PR if it is breaking links. Running a live server doesn't seem viable in CI unless there is some example of it already.

from documentation.

har00ga avatar har00ga commented on August 22, 2024

@prestonvanloon Works for me, would be awesome to implement that if possible. Seeing as it works on the live server as well it would be good to make a note in the README that contributors should use the link tool before submitting a PR to reduce friction at merge time

from documentation.

har00ga avatar har00ga commented on August 22, 2024

#101 Link checking to be included as a step in this

from documentation.

prestonvanloon avatar prestonvanloon commented on August 22, 2024

If someone can help implement this as a github action, we could add it as a PR requirement.

from documentation.

har00ga avatar har00ga commented on August 22, 2024

@prestonvanloon Haven't worked with GH Actions before but will read into it this week

from documentation.

har00ga avatar har00ga commented on August 22, 2024

#175

from documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.