Reduce References to cli.Context of the Sharding Node in its Services about prysm HOT 3 CLOSED

Closed by #149

from prysm.

To shine more light on this: my specific suggestion was to add abstraction around flag access for the users of the sharding node.

I.e. change this

actor := n.Context().GlobalString(utils.ActorFlag.Name)

to this

actor := n.Actor()

Why? It's easier to use, consume, and understand for the bit of code that needs to know what type of actor to operate in this specific example. It probably makes it easier to test as well.

There may be only one instance of this specific example, but it would be worth looking at other ways to improve our interfaces as part of this issue.

from prysm.

Great point, this will reduce the need for certain imports and makes the code a lot more clear. I already started fixing this in #137 where I use n.DataDir() as an abstraction over the cli context. This, along with the DepositFlag are the only two scenarios here but we will keep this in mind moving forward. I'll fix the DepositFlag situation in a different PR.

from prysm.