Giter VIP home page Giter VIP logo

Comments (11)

enriquefynn avatar enriquefynn commented on July 30, 2024

Isn't better to test directly with go?

from prysm.

nisdas avatar nisdas commented on July 30, 2024

I dont think there is any framework for unit testing solidity in go

from prysm.

enriquefynn avatar enriquefynn commented on July 30, 2024

Calling functions in the SMC and checking the outcome can be done in go.

from prysm.

nisdas avatar nisdas commented on July 30, 2024

We could do the solidity testing using truffle then run a separate set of tests in go using the bindings to test functions in the SMC

from prysm.

prestonvanloon avatar prestonvanloon commented on July 30, 2024

Testing from Go would be a more end to end test. We would need to simulate or run an actual chain to test the contract via Go. We could/should do both but we could really use some specific unit tests in solidity.

from prysm.

enriquefynn avatar enriquefynn commented on July 30, 2024

We can mock it, did some in #21
I don't see any benefit from testing within truffle

from prysm.

prestonvanloon avatar prestonvanloon commented on July 30, 2024

Discussed in gitter. Truffle provides a test runner and some assertion libraries, but introduces new development dependencies. Given that we already can run tests and use Go's standard testing library, we should continue to write tests in go for purposes of unit testing the validator management contact.

from prysm.

vs77bb avatar vs77bb commented on July 30, 2024

@rauljordan Great to meet you at ETHDenver - Vivek from Gitcoin here. Would it be helpful to bounty this to our dev community? Is there another issue which is higher priority at this time + fits the 'good first issue' mold for someone wanting to come contribute? Great work here so far!

from prysm.

rauljordan avatar rauljordan commented on July 30, 2024

Can this be closed? We are testing using the go bindings and I think that is good enough for our purposes.

from prysm.

terencechain avatar terencechain commented on July 30, 2024

We are already doing this under sharding_manager_tests.go

from prysm.

rauljordan avatar rauljordan commented on July 30, 2024

from prysm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.