Comments (11)
The only thing we haven't really been following is the commit message structure. Let's make sure everyone on the team is on the same page.
from prysm.
Web3.py and py-evm's commit message structure:
- What was wrong?
- TODO
- How was it fixed?
- Cute Animal Picture
from prysm.
Vyper's commit message structure:
- What I did
- How I did it
- How to verify it
- Description for the changelog
- Cute Animal Picture
from prysm.
Solidity doesn't have a commit message structure, it refers to issue
from prysm.
Casper's commit message structure:
- Issue
- Proposed implementation
from prysm.
I reached out to the folks at ethereum/go-ethereum to get a copy of their gitcop configuration. I've also enabled gitcop (I think), but it might not be the same rules until I hear back.
I'll rebase all of our commit messages, but it will take a me a little while to do it since there are 3 months worth of messages that do not conform to the rule.
From now on, we must use the sharding:
prefix to our commit messages.
from prysm.
from prysm.
Yeah, any clue how to do this properly? I tried git rebase -i bc76d3e96886cd2e354605bec40d326477090015
and changed the commit messages in the git-todo along with setting it to "reword", but it seems to have not reworded anything and just double signed all commits. master...prestonvanloon:forced-rebase
from prysm.
What do we need to get this closed? Do we just have to update all our previous commit msgs?
from prysm.
Yeah and enable gitcop. I have the settings from Peter in an email. If you know of an easy way to update all of the previous messages, let me know!
from prysm.
We will no longer be dependent on Geth. Closing.
from prysm.
Related Issues (20)
- Reports of Windows users losing peers #13431 HOT 6
- are the fields in chain_reorg event response reversed?
- Google Container Registry Shutdown HOT 4
- Incompatible with k8s.io/[email protected]+ HOT 2
- Out of memory (OOM) - Prysm killed HOT 5
- Prysm Killed - Out of Memory HOT 6
- Cli args CMD to start prysm without GRPC gateway but http rest api HOT 1
- cannot obtain database lock, database may be in use by another process HOT 2
- Using Prysm BN with the `--bootstrap-node` with and invalid signature leads to a wrong error message.
- how to fethc data from network level? HOT 10
- OOM and Utilization Issues when using Prysm v5 HOT 9
- Maybe Clock Drift on Windows Server HOT 3
- I've been syncing Ethereum for three days, and it still hasn't completed! HOT 3
- Local devnet blocked when running for too long. HOT 4
- run local testnet failed: could not set config params: version 0x05000000 for fork electra in config interop conflicts with existing config named=mainnet HOT 1
- local devnet, how to start with "canun" fork by default
- Check conten-type and return 415 if not supported by route HOT 1
- Beacon node not honoring p2p-max-peers value
- beacon-chain invalid memory addreses or nil pointer dereference HOT 2
- "Unrecognized option" when I execute "bazel run" HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prysm.