Packet decoding will need to account for pump model about rileylink HOT 4 CLOSED

That makes sense; I have that separation (packet encoding vs message semantics) in the https://github.com/ps2/minimed_rf library as well, and I'd like to keep them roughly in sync.

from rileylink.

One thing I'd like to do differently than minimed_rf, is to have the message classes be aware of the first 5 bytes. I plan to update minimed_rf message classes to be the same way

from rileylink.

When separate message types have a common field type that is parsed in varying ways determined by pump model, then it makes sense for that decoding to be shared, and configurable by pump model. I would think that there is still a single message type that can handle the various pumps.

But I might not be understanding what's common and what varies completely. We'd need to discuss specifics, I think, to get the best layout. For now, I agree 100% on separating message semantics from the 4b6b encoding, crc calculation, and other rf packet details.

from rileylink.

This issue was moved to ps2/rileylink_ios#1

from rileylink.